[gui] use a crash reporter dialog allowing users to report full of information issues

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: parkouss, Assigned: parkouss)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
So basically GUI errors are a bit hard to track, and often users are just going to report "I do that, and it does not work".

To fix the bug, this will often lacks information. :)

So the purpose of this bug is to create something that will catch exception (probably done in Qt event loop) and open up a "Crash report" dialog, with useful information such as the error message, stack trace, os, arch, python version.
(Assignee)

Comment 1

3 years ago
Created attachment 8657584 [details] [review]
crash report dialog

Hey Jonathan, I wonder if you have the time to look at this ? If you don't, please redirect the review to :wlach!

I tested it, and it seems to works well. :)

Thanks!
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8657584 - Flags: review?(jonathan.pigree)

Comment 2

3 years ago
Hello Julien. If you want to merge this very quickly then perhaps I will have to redirect to wlach.
If not, I will try to give it some tests this week.
(Assignee)

Updated

3 years ago
Blocks: 1202404
(Assignee)

Comment 3

3 years ago
Comment on attachment 8657584 [details] [review]
crash report dialog

So I discussed with Jonathan and he is pretty busy these times, so I wonder if MikeLing you could have a look at that PR and tell me what do you think of it ?

Anyway the discussion with Jonathan was great, and I just udpdated the code here to:

 - add a "Prevent this dialog from opening again" checkbox
 - do not show the dialog if there is already one

MikeLing, please tell me if you can look at it, and we can discuss that bug on irc if needed!

Thanks :)
Attachment #8657584 - Flags: review?(jonathan.pigree) → review?(sabergeass)

Comment 4

3 years ago
Yes, I can do this ;)  will give your reply ASAP (for working on the issue about apply size limit to gui)

Comment 5

3 years ago
Comment on attachment 8657584 [details] [review]
crash report dialog

Hmm, must admin that it's too hard to get it crash. So I finally give up to make the crash happen and just run the test locally. The result all looks good to me ;)
Attachment #8657584 - Flags: review?(sabergeass) → review+
(Assignee)

Comment 6

3 years ago
(In reply to MikeLing from comment #5)
> Comment on attachment 8657584 [details] [review]
> crash report dialog
> 
> Hmm, must admin that it's too hard to get it crash. So I finally give up to
> make the crash happen and just run the test locally. The result all looks
> good to me ;)

He, we are doing our best to make the gui not crash!

One way to go was to just change the code somewhere, like add a raise Exception('message').
Anyway I tested it, this should be all good. Let's land that!
(Assignee)

Comment 7

3 years ago
Landed in https://github.com/mozilla/mozregression/commit/e7e6c60c468af3269d289da570d19eb144e7fa07.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.