1202247 - Text selection action bar uses old 3-dot menu icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

STR
1) Open a web page
2) Long press to select text

Expected: action bar has Material (round) 3-dot menu icon
Actual: action bar uses old (square) 3-dot menu icon

I thought we removed the asset so perhaps it's using something built into Android.

Originally implemented in bug 1148550, which landed in 43 (tracking).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

There's a menu_light drawable [1] (argh!) which is used in the GeckoActionBar.Button.MenuButton [2] style, which is used in the action bar layout [3].

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-xhdpi/menu_light.png
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/styles.xml?rev=94a35ea51e6a#731
[3]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/actionbar.xml?rev=426fabc9a7fa#26

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: v11+ screenshot (fixed)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I don't think this applies to GB devices because they don't have a soft menu button.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1202247 - Use new menu asset in action bar & remove old assets. r=liuche

Bug 1202247 - Use new menu asset in action bar & remove old assets. r=mhaigh

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8659413 [details]
MozReview Request: Bug 1202247 - Use new menu asset in action bar & remove old assets. r=liuche

Bug 1202247 - Use new menu asset in action bar & remove old assets. r=mhaigh

I wasn't able to test this on GB because I don't have a device with a soft menu
key, but I'm pretty sure that's because they don't exist.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8659413 [details]
MozReview Request: Bug 1202247 - Use new menu asset in action bar & remove old assets. r=liuche

Bug 1202247 - Use new menu asset in action bar & remove old assets. r=liuche

I wasn't able to test this on GB because I don't have a device with a soft menu
key, but I'm pretty sure that's because they don't exist.

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8659413 [details]
MozReview Request: Bug 1202247 - Use new menu asset in action bar & remove old assets. r=liuche

https://reviewboard.mozilla.org/r/18817/#review16927

I don't see you removing the drawable resource menu_light, and these styles are the only places where they're used. However, I still see menu_light in mxr. Will you remove those drawables?

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/18817/#review16927

Yeah, meant to do that.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/936f4834fc8b

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/936f4834fc8b

Comment 11

[u549602]

Verified as fixed on latest Nightlty