1202266 - libstagefright build failure using hardening flags

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Johannes Pfrang [:johnp]]

Using '-Wformat-security -Wformat -Werror=format-security' as CXXFLAGS building libstagefright fails:

    cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
    cc1plus: some warnings being treated as errors

    In the directory  /gecko-dev/obj-x86_64-unknown-linux-gnu/media/libstagefright

Reason: media/libstagefright/moz.build adds -Wno-format to CXXFLAGS
Fix: Also add -Wno-format-security in the same place

Comment 1

[Johannes Pfrang [:johnp]]

Attachment: Suppress '-Wformat-security' in libstagefright CXXFLAGS

Comment 2

[Johannes Pfrang [:johnp]]

Comment on attachment 8657602 [details] [diff] [review]
Suppress '-Wformat-security' in libstagefright CXXFLAGS

cajbir, you reviewed bug 1017110 were the warning suppression were added.
Adding -Wno-format-security just prevents a simple build failure and shouldn't have any other impact.

Comment 3

[cajbir (:cajbir)]

Comment on attachment 8657602 [details] [diff] [review]
Suppress '-Wformat-security' in libstagefright CXXFLAGS

Looks good to me but passing to :kft to find a media reviewer.

Comment 4

[Johannes Pfrang [:johnp]]

Attachment: Suppress '-Wformat-security' in libstagefright CXXFLAGS

Rebase on top of bug 1203005.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04aa9165c832

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/04aa9165c832