Closed Bug 1202266 Opened 8 years ago Closed 8 years ago

libstagefright build failure using hardening flags

Categories

(Core :: Audio/Video, defect, P2)

Product:
Core
Component:
Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: johnp, Assigned: johnp)

Details

Attachments

(1 file, 1 obsolete file)

Suppress '-Wformat-security' in libstagefright CXXFLAGS
796 bytes, patch
ajones
: review+
Details | Diff | Splinter Review 
Using '-Wformat-security -Wformat -Werror=format-security' as CXXFLAGS building libstagefright fails:

    cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
    cc1plus: some warnings being treated as errors

    In the directory  /gecko-dev/obj-x86_64-unknown-linux-gnu/media/libstagefright

Reason: media/libstagefright/moz.build adds -Wno-format to CXXFLAGS
Fix: Also add -Wno-format-security in the same place
Assignee: nobody → johnp
Comment on attachment 8657602 [details] [diff] [review]
Suppress '-Wformat-security' in libstagefright CXXFLAGS

cajbir, you reviewed bug 1017110 were the warning suppression were added.
Adding -Wno-format-security just prevents a simple build failure and shouldn't have any other impact.
Attachment #8657602 - Flags: review?(cajbir.bugzilla)
Component: Build Config → Audio/Video
Comment on attachment 8657602 [details] [diff] [review]
Suppress '-Wformat-security' in libstagefright CXXFLAGS

Looks good to me but passing to :kft to find a media reviewer.
Attachment #8657602 - Flags: review?(cajbir.bugzilla) → review?(ajones)
Attachment #8657602 - Flags: review?(ajones) → review+
Keywords: checkin-needed
Rebase on top of bug 1203005.
Attachment #8657602 - Attachment is obsolete: true
Attachment #8659344 - Flags: review?(ajones)
Priority: -- → P2
Attachment #8659344 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/04aa9165c832
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.