1202342 - Expose getAssertions to the System app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

In order to ease the implementation of the Sync Manager that is being developed on bug 1196096, we need to expose the getAssertion method to the System app.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1202342.fxa.getassertion > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Hey Sam, would you mind taking a look to this patch, please? It is simply exposing the getAssertion method to the System app via content/chrome events. Thanks!

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8657822 [details] [review]
[gaia] ferjm:bug1202342.fxa.getassertion > mozilla-b2g:master

Kevin, this patch is quite similar to the one for bug 1182071. I am adding the 'getAssertion' method to FxAccountsClient. I had to remove the way we dynamically added/removed the chrome event listener cause we can have more than two listeners in place which made the listener to be remove before it should. It's not a big deal, but once we move FxAccountsClient to Promises (bug 1202449), it'll be easier to take the dynamic addition/removal of the listener.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 5

[Sam Penrose]

Comment on attachment 8657865 [details] [diff] [review]
v1

This looks fine, thanks Fernando. Nit: resolve the comment conflict.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8657822 [details] [review]
[gaia] ferjm:bug1202342.fxa.getassertion > mozilla-b2g:master

I'm not sure when or how we're going to use this, but the code seems fine to me. Thanks!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d5a2dd85d607d081041cbae67aa9c4756410318
Bug 1202342 - Expose getAssertions to the System app. r=spenrose

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/1d8c4b6237f2421bab6b4ae2c284f4596d24bf79

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d5a2dd85d60