Remove MDSM::mPlayDuration

RESOLVED FIXED in Firefox 43

Status

()

defect
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks 1 bug)

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

After bug 1199562 is landed, MDSM can always rely on the MediaSink to provide the playback position no matter playback is paused or not. We can then remove |mPlayDuration| which existed to provide the playback position when playback is paused.
Blocks: 1199098
Depends on: 1199562
Blocks: 1202540
Bug 1202351 - Remove MDSM::mPlayDuration.
Attachment #8658494 - Flags: review?(cpearce)
Comment on attachment 8658494 [details]
MozReview Request: Bug 1202351 - Remove MDSM::mPlayDuration.

https://reviewboard.mozilla.org/r/18615/#review16755

::: dom/media/MediaDecoderStateMachine.cpp:2549
(Diff revision 1)
> -
> +  auto clockTime = mMediaSink->GetPosition(aTimeStamp);

In general, "auto" should be used sparingly, and only when using it increases readability. Like for knarly template types on iterators.

When I see "auto" here I have to think to figure out what type it is. So I prefer we don't use "auto" for primitive types.
Attachment #8658494 - Flags: review?(cpearce) → review+
https://reviewboard.mozilla.org/r/18615/#review16755

> In general, "auto" should be used sparingly, and only when using it increases readability. Like for knarly template types on iterators.
> 
> When I see "auto" here I have to think to figure out what type it is. So I prefer we don't use "auto" for primitive types.

Will replace auto with int64_t. Thanks for the review!
Assignee: nobody → jwwang
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/c1d187c685d1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.