Implement backport fix for 'lock-immeditaly' bug 1186100 as FMD hotfix

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
FindMyDevice
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cr, Assigned: cr)

Tracking

({sec-other})

unspecified
FxOS-S7 (18Sep)
ARM
Gonk (Firefox OS)
sec-other
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 fixed, b2g-v2.2r fixed, b2g-master unaffected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The current patch for bug 1186100 works with the new lockscreen state manager which is not available in earlier version.

To keep things simple, the backport can be implemented as hotfix in Find My Device instead: When it requests to lock immediately, it would need to set the pass code timeout setting to 'immediately' before signalling 'lock-immediately'.
(Assignee)

Updated

3 years ago
Assignee: nobody → cr
Blocks: 1186100
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → affected
status-b2g-master: --- → unaffected
Keywords: sec-other
Created attachment 8657929 [details] [review]
[gaia] cr:immediatelockfix-v2.2 > mozilla-b2g:v2.2
(Assignee)

Comment 2

3 years ago
Comment on attachment 8657929 [details] [review]
[gaia] cr:immediatelockfix-v2.2 > mozilla-b2g:v2.2

Alexandre, could you review this trivial hotfix, please? STR in bug 1186100.
Attachment #8657929 - Flags: review?(lissyx+mozillians)
(Assignee)

Comment 3

3 years ago
Landing this depends on bug 1195872 being fixed.
Depends on: 1195872
Attachment #8657929 - Flags: review?(lissyx+mozillians) → review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8657929 [details] [review]
[gaia] cr:immediatelockfix-v2.2 > mozilla-b2g:v2.2

[Approval Request Comment]

[Bug caused by] (feature/regressing bug #):
Design flaw. Hotfix for bug 1186100.

[User impact] if declined:
FindMyDevice lock command will not passcode-lock immediately when the user had configured a long timeout. Thief can continue to use the device until timeout occurs.

[Testing completed]:
Local tests passing.

[Risk to taking this patch] (and alternatives if risky):
Low risk. One-liner change in FMD which forced the pass code timeout to 'immediately'.

[String changes made]:
None

Please also give v2.2r approval.
Attachment #8657929 - Flags: approval-gaia-v2.2?(mpotharaju)
Hey CR, is the dependent bug not required before we land this?
Flags: needinfo?(cr)
(Assignee)

Comment 6

3 years ago
(In reply to Mahendra Potharaju [:mahe] from comment #5)
> Hey CR, is the dependent bug not required before we land this?

This patch isn't technically dependent on 1195872 which is about broken test automation on all non-master branches. Meanwhile sheriffs have been landing a few other in the blind on v2.2. I marked my 2.2 patches as dependent just to raise awareness.
Flags: needinfo?(cr)
Thank you Christiane.
Comment on attachment 8657929 [details] [review]
[gaia] cr:immediatelockfix-v2.2 > mozilla-b2g:v2.2

Approved to apply patch on v2.2. 

Thanks
Attachment #8657929 - Flags: approval-gaia-v2.2?(mpotharaju) → approval-gaia-v2.2+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/0a0781fb620d96b900aaeb744e03515efbdd99bb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-v2.2: affected → fixed
Resolution: --- → FIXED
status-b2g-v2.2r: --- → fixed
Keywords: checkin-needed
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.