Closed Bug 1202568 Opened 4 years ago Closed 4 years ago

Cherry-pick -Wshadow warning fixes from upstream double-conversion

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1. Cherry-pick some -Wunused-variable and -Wshadow warning fixes from upstream double-conversion. These individual fixes are necessary to compile xpcom/* with -Werror=shadow.

double-conversion/utils.h:144:31: warning: declaration of 'length' shadows a member of 'this' [-Wshadow]
double-conversion/utils.h:188:7: warning: declaration of 'size' shadows a member of 'this' [-Wshadow]

https://github.com/google/double-conversion/commit/2e8462ab9f043e64532bc5bb6e64d739020ad3df#diff-0a51c39b68995102239a15cafaf4f78eR519

https://github.com/google/double-conversion/commit/24099d52dca15a9ce7c90b7e6226cc33dde83071#diff-944c06f8264af4d8f28d9d9123d3667cL170

https://github.com/google/double-conversion/commit/24099d52dca15a9ce7c90b7e6226cc33dde83071#diff-944c06f8264af4d8f28d9d9123d3667cL213

2. Remove fix-gcc-warnings.patch, a local fix (bug 984073) that is no longer necessary to fix the -Wunused-variable warning cherry-picked in #1.

@ Ms2ger, if you prefer, I have another patch queue that pulls all of the latest upstream double-conversion changes, but it is a fair amount of churn without any critical bug fixes.
Attachment #8658026 - Flags: review?(Ms2ger)
Comment on attachment 8658026 [details] [diff] [review]
cherry-pick-Wshadow-fixes.patch

Review of attachment 8658026 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on this or on the full sync-with-upstream, as you prefer.
Attachment #8658026 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/0003682e05b9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.