1202573 - Use more restrictive slug regex ^[A-Za-z0-9_-]{8}[Q-T][A-Za-z0-9_-][CGKOSWaeimquy26-][A-Za-z0-9_-]{10}[AQgw]$ in taskcluster schemas

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

Currently in our schemas we are using

^[a-zA-Z0-9-_]{22}$

to validate slugids in our schemas. However, this does not guarantee a v4 compliant uuid when decoded. The more restrictive regex:

^[A-Za-z0-9_-]{8}[Q-T][A-Za-z0-9_-][CGKOSWaeimquy26-][A-Za-z0-9_-]{10}[AQgw]$

does guarantees conformity. We should therefore update our schemas to use this regex instead.

This bug originated in https://bugzilla.mozilla.org/show_bug.cgi?id=1194767#c58.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/task-graph-scheduler

Comment 2

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-queue

Comment 3

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-index

Comment 4

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-scheduler

Comment 5

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/aws-provisioner

Comment 6

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-auth

Comment 7

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-base

Comment 8

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/taskcluster-github

Comment 9

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request taskcluster/aws-purge-cache

Comment 10

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658221 [details] [review]
Github Pull Request taskcluster/taskcluster-base

Landed...

Comment 11

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658231 [details]
Github Pull Request taskcluster/aws-purge-cache

merged

Comment 12

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658200 [details] [review]
Github Pull Request taskcluster/taskcluster-scheduler

merged... might take a while to rollout, as it is low priority, so will ride the next thing..

Comment 13

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658197 [details] [review]
Github Pull Request taskcluster/taskcluster-index

merged

Comment 14

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658181 [details] [review]
Github Pull Request taskcluster/taskcluster-queue

merged

Comment 15

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658177 [details] [review]
Github Pull Request taskcluster/task-graph-scheduler

merged

Comment 16

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8658216 [details] [review]
Github Pull Request taskcluster/taskcluster-auth

merged

Comment 17

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8658231 [details]
Github Pull Request taskcluster/aws-purge-cache

>https://github.com/taskcluster/taskcluster-purge-cache/pull/2

Comment 18

[Pete Moore [:pmoore][:pete]]

The only thing left to do is to publish all the schemas....

I thought this was automatic, but I investigated, and the schemas have not all been (automatically) updated.

I spotted: https://github.com/taskcluster/taskcluster-auth/commit/17cff9af50f019a30e60beb0d1f81a2a9126880c#diff-354f30a63fb0907d4ad57269548329e3

What is the process for deploying our apps based on taskcluster-base into heroku? Which of them are automatic, which ones need to be deployed manually, and what is the rationale behind automatic/not-automatic for each of them? Also, do *all* apps automatically update their schemas on push to heroku, or is this a manual step for any of the apps?

Thanks!

Comment 19

[Pete Moore [:pmoore][:pete]]

Example of non-automatic update
===============================

https://github.com/taskcluster/taskcluster-auth/blob/master/schemas/constants.js#L12
https://github.com/taskcluster/taskcluster-auth/blob/master/schemas/client-credentials-response.yml#L11

is inconsistent with:

http://schemas.taskcluster.net/auth/v1/client-credentials-response.json (line 10)

Comment 20

[Pete Moore [:pmoore][:pete]]

jhford pointed me to the heroku web interface, where I could see that most of the repos did not have auto-deployment from github master branch enabled.

I did manual deployments of the components I could (I did not have access to deploy aws provisioner, but jhford told me that one is automatic, and I've asked selena for access for future) and I could not deploy taskcluster-github either - I'll ping mrrrgn.