1202582 - [Presentation WebAPI] Ensure incoming messages are well delivered to receiver pages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Sean Lin [:seanlin] (inactive from Mar 2016)]

|PresentationSessionTransport| starts to consume incoming data when the data channel becomes connected [1][2]. And once some data come in, it notifies the correspondent |PresentationSessionInfo| [3][4]. However, at receiver side (presenting context), the session info might not have registered the session listener at this moment yet, so the incoming message might thus get dropped without notifying the receiver page [5].

We may consider not to start consuming incoming data until the session listener is registered. And then the incoming data can be automatically buffered until we're ready to handle them.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/PresentationSessionTransport.cpp?offset=0#395
[2] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/PresentationSessionTransport.cpp#255
[3] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/PresentationSessionTransport.cpp#483
[4] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/PresentationSessionInfo.cpp#320
[5] https://dxr.mozilla.org/mozilla-central/source/dom/presentation/PresentationSessionInfo.cpp#328

Comment 1

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Part 1 - PresentationSessionTransport

Add a method to |nsIPresentationSessionTransport| to control the timing of start handling incoming data.

Comment 2

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Part 2 - PresentationSessionInfo

Ensure presentation session doesn't consume incoming data until the session listener is registered.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658125 [details] [diff] [review]
Part 2 - PresentationSessionInfo

Ahaa, EnableDataNotification is added in the other patch.

Comment 4

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Part 1 - PresentationSessionTransport

Comment 5

[Sean Lin [:seanlin] (inactive from Mar 2016)]

Attachment: Part 2 - PresentationSessionInfo

Comment 6

[Sean Lin [:seanlin] (inactive from Mar 2016)]

The try-run. FYI.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8963ae3bad5

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/8985f4ca6bbf
https://hg.mozilla.org/integration/b2g-inbound/rev/a3fe551ea06b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8985f4ca6bbf
https://hg.mozilla.org/mozilla-central/rev/a3fe551ea06b