Closed Bug 1202626 Opened 9 years ago Closed 9 years ago

Stop storing each revision's commit_timestamp

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

At the moment we store both the resultset's time (as push_timestamp) and the commit timestamp for each revision (as commit_timestamp). The latter is not surfaced in the UI anywhere, and IMO really isn't something we need - we're only ever thinking in terms of whole pushes - the only time the individual revisions are useful is when displaying the list of SHAs+authors in the UI. However the date adds little value there (it is typically the author date which can be in the past and has little relation to the date the commit landed - which is already stored as push_timestamp). Let's just remove it.
Attachment #8664318 - Flags: review?(mdoglio)
Status: NEW → ASSIGNED
Attachment #8664318 - Flags: review?(mdoglio) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/ba39c25fa20609e2845d9dcfc19f15b159411a28 Bug 1202626 - Stop storing each revision's commit_timestamp It's unused in the UI and doesn't add any value, since we're normally much more interested in the push_timestamp. This can land without causing errors, since the field is DEFAULT NULL, so can be dropped at our leisure later.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1210174
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: