1202731 - Add a way to link to a particular set of results in comparechooser UI

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

To make sharing results from a particular test easier, it'd be great to be able to link to the "sessionrestore opt" results by linking to a particular fragment in the URL.  Something like:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=fx-team&originalRevision=65e92b72d584&newProject=try&newRevision=2b95b3d44786#sessionrestore-opt

To get that to work there'd need to be a corresponding ID set on each table.compare-table on the page.  And then maybe a '#' link could show up next to the test title on hover of the table.

Comment 1

[Julien Pagès (:parkouss)]

I have something that is nearly working here:

https://github.com/parkouss/treeherder/commit/df9facdc35a23b0e6e72889b7791c469ef5c850d

But, it does not work for the first page load! I believe this is a ui-router *specificity* (bug?) - not sure how to work around this. I'm don't know much about about angular and ui-router though, maybe :wlach can help ?

Comment 2

[William Lachance (:wlach)]

Nothing jumps out offhand, but I'm far from being an angular expert either. I just dive into it where needed. :)

Could you file a PR for the change and f? me on it? We can take it from there.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

:bgrins, would the filter work for you:
https://treeherder.mozilla.org/perf.html#/compare?originalProject=fx-team&originalRevision=65e92b72d584&newProject=try&newRevision=2b95b3d44786&framework=1&filter=session&showOnlyImportant=0

Comment 4

[Brian Grinstead [:bgrins]]

Yes that helps!  However a couple of notes:

1) The "tests with no results" section is huge on that particular push, which means the filtered results aren't visible in the viewport when loading.  Could that section be collapsed and/or moved to the bottom to the page so the relevant results are in the viewport on loading?
2) Partly because of (1) but also in general, it'd still be great to have IDs added to the DOM for each section heading so I can add it to the URL and have the page immediately point to that section.  It wouldn't even necessarily need to be surfaced to the UI, I can manually find the ID with devtools and append it to the URL.

And something I believe is unrelated to the 'filter' feature but I'll add anyway since I bumped into it: I am consistently getting slow script warnings when loading that page

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Brian Grinstead [:bgrins] from comment #4)

Yes that helps! However a couple of notes:

1. The "tests with no results" section is huge on that particular push,
   which means the filtered results aren't visible in the viewport when
   loading. Could that section be collapsed and/or moved to the bottom to the
   page so the relevant results are in the viewport on loading?

I believe I fixed this issue.

2. Partly because of (1) but also in general, it'd still be great to have
   IDs added to the DOM for each section heading so I can add it to the URL and
   have the page immediately point to that section. It wouldn't even
   necessarily need to be surfaced to the UI, I can manually find the ID with
   devtools and append it to the URL.

This is something we're still lacking, but is a small useful feature.

And something I believe is unrelated to the 'filter' feature but I'll add
anyway since I bumped into it: I am consistently getting slow script
warnings when loading that page

This has been addressed, as we refactored the endpoints. They are now faster in response times.

Comment 6

[Ionuț Goldan [:igoldan]]

Based on comment 4, the new requirements for this ticket are:

• provide id at test header level
• provide id at test signature level
• provide a paragraph anchor
  • so developers can share the Compare view already focused on a particular test

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5262

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5320

Comment 9

[Ionuț Goldan [:igoldan]]

This just got merged to master.

Comment 10

[Ionuț Goldan [:igoldan]]

This just got deployed to production.