1202740 - [new homescreen] 'Enter search or address' is replaced by 'New home screen' when switching locales

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Théo Chevalier]

User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

STR:

Enable new homescreen
- Switch to French

Actual:
'New home screen' is displayed.

Expected:
'Recherche ou adresse' is displayed ('Enter search or address' in French

Comment 1

[Théo Chevalier]

Attachment: 2015-09-07-10-26-55.png

Comment 2

[Théo Chevalier]

Tested with today's master build on Aries

Comment 3

[Francesco Lodolo [:flod]]

The only reference I can find around is in the manifest
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/manifest.webapp#L2

Related to bug 1174727?

Comment 4

[Théo Chevalier]

Might also be Bug 1188350 if this string is considered as document.title in the code

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1202740-Enter-search-address-replaced-New-home-screen-switching-locales > mozilla-b2g:master

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8662388 [details] [review]
[gaia] gmarty:Bug-1202740-Enter-search-address-replaced-New-home-screen-switching-locales > mozilla-b2g:master

Alberto, can you take a look at this patch?

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8662388 [details] [review]
[gaia] gmarty:Bug-1202740-Enter-search-address-replaced-New-home-screen-switching-locales > mozilla-b2g:master

r=me with a unit test covering this js change. Thanks!

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/fe53f73c4382e13ba54bc688b37c9378223d8f2f

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: 'Enter search or address' shows normally when switching to French.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151029150245
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1fbc958f75576446a57cf93406db87b51b12911d
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151029.182818
Firmware Date          Thu Oct 29 18:28:30 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151030012032
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6d1e12f5725b56453e368b960e873261e0d48b5a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151030.003706
Firmware Date          Fri Oct 30 00:37:14 UTC 2015
Bootloader             s1

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.png