120275 - javascript strict warnings in charsetOverlay.js

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Henrik Gemal]

Warning: redeclaration of var contentArea
Source File: chrome://global/content/charsetOverlay.js
Line: 271, Column: 12
Source Code:
var contentArea = window.document.getElementById("appcontent");

"contentArea" is being defined in:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/charsetOve
rlay.js#255

but also being defined in:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/charsetOve
rlay.js#271

build 20020115

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch for redeclaration of contentArea strict warning

Comment 2

[Alex Vincent [:WeirdAl]]

Adding patch keyword as I cannot check this in.  Note this is a completely safe
patch for 0.9.8, recommend getting a= from one of the drivers.

Comment 3

[timeless]

Comment on attachment 65237 [details] [diff] [review]
patch for redeclaration of contentArea strict warning

branch only, weirdal has volunteered to do the right thing for trunk

Comment 4

[Roy Yokoyama]

Alex: Do we really need this for 0.9.8?  I am not sure if we can get an approval
from drivers. 

Comment 5

[Alex Vincent [:WeirdAl]]

I think it's worth trying.

Here's the problem:  We get a strict warning every time we open a browser window
(I'm not sure if it's tab or window), every time we open a mail/news window,
every time we open an Editor window.  These strict warnings, combined with the
errors, generate measurable performance hits with warnings disabled in the
prefs, and with warnings enabled, they generate very noticeable perf hits --
given enough of them (100-200), the browser becomes unusuable.  Clearing the JS
Console doesn't help there.  The perf hit lingers long after the actual warning
or error is thrown.

Comment 6

[Brendan Eich [:brendan]]

a=[e-mail] for the frozen 0.9.8 trunk, when the tree opens to
approved checkins (we have blockers today).

/be

Comment 7

[Roy Yokoyama]

alex: Now the tree is open, can you check in?  Do you have a write access? If
not, I can do it for you. 

Comment 8

[Alex Vincent [:WeirdAl]]

Negative to both -- also, the patch is awaiting an sr=.

I don't know if that's your dept. or not, but that word has not been given yet.

Comment 9

[Roy Yokoyama]

brendan: do we need /sr for js changes?
If so, then can you give /sr=? thanks

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 65237 [details] [diff] [review]
patch for redeclaration of contentArea strict warning

sr=[e-mail]

Comment 11

[Roy Yokoyama]

checked in

Comment 12

[Rui Xu]

Verified.