1202833 - Autophone - CHARGING state should not prevent Autophone shutdown/restart

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Currently, if a phone is in CHARGING state, requests to shutdown/restart Autophone will pause until the phone leaves charging since PhoneWorkerSubProcess.check_battery is called after a test has been set up, PhoneWorkerSubProcess.process_autophone_cmd does not interrupt a test and check_battery does not return until the phone is sufficiently charged.

This can be a problem since when Autophone is shutting down/restarting it disables its pulse listener and no longer consumes pulse messages. If it does not restart in a short enough period of time, the pulse queues can grow past the size limit and be deleted.

I believe I can fix this issue by making check_battery check if the process_autophone_cmd has set the worker's state to SHUTTINGDOWN and to return a 'command' with interrupt True and a reason related to interrupting a charging device due to a shutdown request. I'll confirm via testing.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1202833-v1.patch

This works well for me.

https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=bbdcc9af68be&exclusion_profile=false&filter-searchStr=autophone

Comment 2

[Bob Clary [:bc] (inactive)]

Thanks!