1203057 - On sync_projects, empty translations are marked as unapproved

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect)

Description

[Matjaz Horvat [:mathjazz]]

I noticed that in 3 Firefox OS projects, in this file only:
https://pontoon.mozilla.org/sl/firefox-os-20/apps/clock/clock.properties/

All empty translations were marked as translated but unapproved after sync.

Comment 1

[Matjaz Horvat [:mathjazz]]

Even when I approve these FxOS strings, on next sync_projects they get unapproved again.

Also, seems like sometimes even non-empty approved strings get unapproved (those 2 strings were previously approved):
https://pontoon.mozilla.org/sl/mozillaorg/privacy/principles.lang/

Comment 2

[Osmose [:osmose, :mkelly]]

> Also, seems like sometimes even non-empty approved strings get unapproved (those 2 strings were previously approved):
> https://pontoon.mozilla.org/sl/mozillaorg/privacy/principles.lang/

Sounds like a separate bug to me, and I can't replicate. Can you approve those two strings again and see if sync works properly? If not, then we should file a new bug, but if it does work, then we'll have to watch out for it to happen again so we can better figure out the issue.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/fe355f5b56dc513b1e857e44ab56a97c8a9d2fa1
Fix bug 1203057: Allow blank translations in silme.

https://github.com/mozilla/pontoon/commit/ad5902489c1ba10abe355080cd5746e51168f04d
Merge pull request #164 from Osmose/unapproved-blank-strings

Fix bug 1203057: Allow blank translations in silme.