[browser][zh-TW][p12n] Update searchplugin for Yahoo Answers TW, remove CC, and sort the searchplugin list

RESOLVED FIXED

Status

defect
--
major
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: petercpg, Assigned: petercpg)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Posted patch 1170.patch (obsolete) — Splinter Review
Yahoo just migrated Y! Knowledge TW/HK to global Y! Answers platform and the current searchplugin is broken, I'm proposing this bug to update it.

This patch is proposed by 1abcd and the credit goes to DDRPTP on MozTW Forum[1], with my slight revision to remove unneeded changes.


[1] https://forum.moztw.org/viewtopic.php?f=4&t=43258
Attachment #8658678 - Flags: review?
Attachment #8658678 - Flags: review? → review?(francesco.lodolo)
Comment on attachment 8658678 [details] [diff] [review]
1170.patch

Review of attachment 8658678 [details] [diff] [review]:
-----------------------------------------------------------------

A few nits since we're touching this file, but it's almost good to go.

Talking about broken searchplugins: zh-TW is still shipping Creative Commons, but unfortunately it's broken (bug 939804). Do you want to take care of it in this bug? A huge ++ if you put the names in list.txt in alphabetical order.

::: browser/searchplugins/yahoo-answer-zh-TW.xml
@@ +3,1 @@
>  <Description>Yahoo!奇摩知識+</Description>

Please add a MPL2 license header at the beginning of the file (you can copy it from existing searchplugins).

@@ +11,1 @@
>  </SearchPlugin>

Add empty line at the end of the file.
Attachment #8658678 - Flags: review?(francesco.lodolo) → feedback+
Posted patch 1170.patch (obsolete) — Splinter Review
revised per comment 1, changes:

list.txt
- Remove Creative Commons
- Sort alphabetically

yahoo-answer-zh-TW.xml
- Added MPL2 header
- Added empty line in the tail.
Attachment #8658678 - Attachment is obsolete: true
Attachment #8658713 - Flags: review?(francesco.lodolo)
Summary: [browser][zh-TW][p12n] Update searchplugin for Yahoo Answers TW → [browser][zh-TW][p12n] Update searchplugin for Yahoo Answers TW, remove CC, and sort the searchplugin list
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #2)
> - Added MPL2 header

Still missing this bit in the current patch.
Posted patch 1170.patchSplinter Review
third try.
Attachment #8658713 - Attachment is obsolete: true
Attachment #8658713 - Flags: review?(francesco.lodolo)
Attachment #8658717 - Flags: review?(francesco.lodolo)
Comment on attachment 8658717 [details] [diff] [review]
1170.patch

Review of attachment 8658717 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.
Attachment #8658717 - Flags: review?(francesco.lodolo) → review+
You need to log in before you can comment on or make changes to this bug.