1203088 - [browser][zh-TW][p12n] Update searchplugin for Yahoo Answers TW, remove CC, and sort the searchplugin list

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: 1170.patch

Yahoo just migrated Y! Knowledge TW/HK to global Y! Answers platform and the current searchplugin is broken, I'm proposing this bug to update it.

This patch is proposed by 1abcd and the credit goes to DDRPTP on MozTW Forum[1], with my slight revision to remove unneeded changes.


[1] https://forum.moztw.org/viewtopic.php?f=4&t=43258

Comment 1

[Francesco Lodolo [:flod]]

Comment on attachment 8658678 [details] [diff] [review]
1170.patch

Review of attachment 8658678 [details] [diff] [review]:
-----------------------------------------------------------------

A few nits since we're touching this file, but it's almost good to go.

Talking about broken searchplugins: zh-TW is still shipping Creative Commons, but unfortunately it's broken (bug 939804). Do you want to take care of it in this bug? A huge ++ if you put the names in list.txt in alphabetical order.

::: browser/searchplugins/yahoo-answer-zh-TW.xml
@@ +3,1 @@
>  <Description>Yahoo!奇摩知識+</Description>

Please add a MPL2 license header at the beginning of the file (you can copy it from existing searchplugins).

@@ +11,1 @@
>  </SearchPlugin>

Add empty line at the end of the file.

Comment 2

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: 1170.patch

revised per comment 1, changes:

list.txt
- Remove Creative Commons
- Sort alphabetically

yahoo-answer-zh-TW.xml
- Added MPL2 header
- Added empty line in the tail.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #2)
> - Added MPL2 header

Still missing this bit in the current patch.

Comment 4

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: 1170.patch

third try.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8658717 [details] [diff] [review]
1170.patch

Review of attachment 8658717 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks.

Comment 6

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Committed to all branches, marking this bug as FIXED:
https://hg.mozilla.org/releases/l10n/mozilla-beta/zh-TW/rev/08a10396241a
https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/aac7aa8f5176
https://hg.mozilla.org/l10n-central/zh-TW/rev/aac7aa8f5176

Thanks Flod!