Fullscreen doesn't work correctly for elements with perspective

VERIFIED FIXED in Firefox 42

Status

()

Core
Layout
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: matus.juraj, Assigned: xidorn)

Tracking

({regression})

31 Branch
mozilla44
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
qe-verify +

Firefox Tracking Flags

(firefox41+ wontfix, firefox42+ verified, firefox43+ verified, firefox44 verified, firefox-esr31 affected, firefox-esr38 affected)

Details

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8658681 [details]
fullScreenBug.html

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36

Steps to reproduce:

* Placing embedded youtube video inside an element with perspective
* Opening fullscreen mode

For videos it's a problem, but it happens with any element inside an element with perspective - there is a self explanatory html use case to demonstrate it on simple square element.


Actual results:

Weird blend of things was displayed.


Expected results:

Video in the fullscreen mode should have been displayed.
(For attached use case: Only the element to be in fullscreen should have been displayed.)

Comment 1

2 years ago
pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e05b578dcd6d&tochange=8dafd4b9969a

Suspect: 8dafd4b9969a	Matt Woodrow — Bug 976365 - Make 'perspective' create a containing block for absolute and fixed positioned children. r=dbaron
Blocks: 976365
Status: UNCONFIRMED → NEW
status-firefox40: --- → affected
status-firefox41: --- → affected
status-firefox42: --- → affected
status-firefox43: --- → affected
status-firefox-esr31: --- → affected
status-firefox-esr38: --- → affected
Component: Untriaged → Layout
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Version: 38 Branch → 31 Branch
[Tracking Requested - why for this release]: Web compat regression
tracking-firefox41: --- → ?
tracking-firefox42: --- → ?
tracking-firefox43: --- → ?

Comment 3

2 years ago
Tracked for 42 on wards. It might be too late to fix this in 41, unless there is a patch in the works and can be uplifted in a day or two.
tracking-firefox41: ? → +
tracking-firefox42: ? → +
tracking-firefox43: ? → +

Comment 4

2 years ago
Seems too late to take a fix in 41 for this.
status-firefox41: affected → wontfix
(Assignee)

Updated

2 years ago
Depends on: 1126230
(Assignee)

Comment 5

2 years ago
This can be fixed with a one line pretty low risk stylesheet change. I'm confident that we are able to uplift that change to whatever version we want without causing any regression.

This should eventually be fixed by implementing the top layer, though.
(Assignee)

Comment 6

2 years ago
This should have been fixed in 44. Please confirm.

If we want to have it fixed in earlier version, I'll submit a patch for that.
Xidorn, no need, are you still ok with the uplift?
Flags: needinfo?(quanxunzhen)
(Assignee)

Updated

2 years ago
status-firefox44: --- → fixed
Flags: needinfo?(quanxunzhen)
(Assignee)

Comment 8

2 years ago
Created attachment 8675964 [details] [diff] [review]
patch for uplift
Assignee: nobody → quanxunzhen
Attachment #8675964 - Flags: review?(dholbert)
(Assignee)

Comment 9

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=76da893869bb
Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Seems fine, r=me.
Attachment #8675964 - Flags: review?(dholbert) → review+
If possible, though, this patch should include a test, to be sure the problem's actually fixed.  (And we should take the test on trunk, too.)
(Assignee)

Comment 12

2 years ago
Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Approval Request Comment
[Feature/regressing bug #]: bug 976365
[User impact if declined]: may see broken fullscreen view
[Describe test coverage new/current, TreeHerder]: currently no
[Risks and why]: low risk, just a simple ua stylesheet fix
[String/UUID change made/needed]: n/a
Attachment #8675964 - Flags: approval-mozilla-release?
Attachment #8675964 - Flags: approval-mozilla-beta?
Attachment #8675964 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 13

2 years ago
Created attachment 8675974 [details] [diff] [review]
patch for test

This is the test fix for trunk. I thought I should have added this in bug 1126230, but it seems I didn't.
Attachment #8675974 - Flags: review?(dholbert)
Comment on attachment 8675974 [details] [diff] [review]
patch for test

Thanks! r=me on the test
Attachment #8675974 - Flags: review?(dholbert) → review+
(Assignee)

Comment 15

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0136029e390e363e61540205b9902dcb9f3cb3ec
Bug 1203089 - Add test for fullscreen element in parent with perspective property. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/0136029e390e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Updated

2 years ago
Flags: in-testsuite+
Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Seems safe, taking it to improve the situation with minimal risk.
However, too late for 41.
Should be in 42 beta 9.
Attachment #8675964 - Flags: approval-mozilla-release?
Attachment #8675964 - Flags: approval-mozilla-release-
Attachment #8675964 - Flags: approval-mozilla-beta?
Attachment #8675964 - Flags: approval-mozilla-beta+
Attachment #8675964 - Flags: approval-mozilla-aurora?
Attachment #8675964 - Flags: approval-mozilla-aurora+
Flags: qe-verify+
https://hg.mozilla.org/releases/mozilla-aurora/rev/07e1f182b1d9
status-firefox43: affected → fixed
https://hg.mozilla.org/releases/mozilla-beta/rev/2c672ff8f3fb
status-firefox42: affected → fixed
(Assignee)

Updated

2 years ago
status-firefox40: affected → ---
I was able to reproduce this issue on Firefox 43.0a1 (2015-09-17) under Windows 7 64-bit.

Verified fixed on Firefox 44.0a1 (2015-10-25), Firefox 43.0a2 (2015-10-25) and Firefox 42 Beta 9 (20151022152545) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.