1203089 - Fullscreen doesn't work correctly for elements with perspective

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[matus.juraj]

Attachment: fullScreenBug.html

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.124 Safari/537.36

Steps to reproduce:

* Placing embedded youtube video inside an element with perspective
* Opening fullscreen mode

For videos it's a problem, but it happens with any element inside an element with perspective - there is a self explanatory html use case to demonstrate it on simple square element.


Actual results:

Weird blend of things was displayed.


Expected results:

Video in the fullscreen mode should have been displayed.
(For attached use case: Only the element to be in fullscreen should have been displayed.)

Comment 1

[Alice0775 White]

pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e05b578dcd6d&tochange=8dafd4b9969a

Suspect: 8dafd4b9969a	Matt Woodrow — Bug 976365 - Make 'perspective' create a containing block for absolute and fixed positioned children. r=dbaron

Comment 2

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]: Web compat regression

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 42 on wards. It might be too late to fix this in 41, unless there is a patch in the works and can be uplifted in a day or two.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Seems too late to take a fix in 41 for this.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

This can be fixed with a one line pretty low risk stylesheet change. I'm confident that we are able to uplift that change to whatever version we want without causing any regression.

This should eventually be fixed by implementing the top layer, though.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

This should have been fixed in 44. Please confirm.

If we want to have it fixed in earlier version, I'll submit a patch for that.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Xidorn, no need, are you still ok with the uplift?

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch for uplift

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76da893869bb

Comment 10

[Daniel Holbert [:dholbert]]

Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Seems fine, r=me.

Comment 11

[Daniel Holbert [:dholbert]]

If possible, though, this patch should include a test, to be sure the problem's actually fixed.  (And we should take the test on trunk, too.)

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Approval Request Comment
[Feature/regressing bug #]: bug 976365
[User impact if declined]: may see broken fullscreen view
[Describe test coverage new/current, TreeHerder]: currently no
[Risks and why]: low risk, just a simple ua stylesheet fix
[String/UUID change made/needed]: n/a

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch for test

This is the test fix for trunk. I thought I should have added this in bug 1126230, but it seems I didn't.

Comment 14

[Daniel Holbert [:dholbert]]

Comment on attachment 8675974 [details] [diff] [review]
patch for test

Thanks! r=me on the test

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0136029e390e363e61540205b9902dcb9f3cb3ec
Bug 1203089 - Add test for fullscreen element in parent with perspective property. r=dholbert

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0136029e390e

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8675964 [details] [diff] [review]
patch for uplift

Seems safe, taking it to improve the situation with minimal risk.
However, too late for 41.
Should be in 42 beta 9.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07e1f182b1d9

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c672ff8f3fb

Comment 20

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 43.0a1 (2015-09-17) under Windows 7 64-bit.

Verified fixed on Firefox 44.0a1 (2015-10-25), Firefox 43.0a2 (2015-10-25) and Firefox 42 Beta 9 (20151022152545) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.