1203190 - Laggy clip rect in some cases while scrolling with APZ on desktop

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

smaug found an issue while scrolling on http://hiff.fi/ :

Around the middle of the page there are boxes for "INDUSTRY", "LIPUNMYYNTI", and "PRESS" - scrolling quickly up and down around these boxes, you see the images getting improperly clipped, almost like the clip rect is lagging behind.

Comment 1

[Markus Stange [:mstange]]

That's an interesting effect. The scrolling images whose "clip" lags aren't really clipped - they're covered, by a background-attachment:fixed image that sits on top. And it's those fixed images' clip that lags. So this bug will be fixed by the remaining patches in bug 1166301.

Comment 2

[Markus Stange [:mstange]]

Hmm, looks like bug 1166301 didn't actually fix this.

Comment 3

[Markus Stange [:mstange]]

I'll look into this.

Comment 4

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

Bug 1203190 - Override the visible rect of background-attachment:fixed display items more aggressively. r=mattwoodrow

Comment 5

[Markus Stange [:mstange]]

This is not the greatest patch ever... do you have any better ideas for how to fix it?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Can you explain more what the problem is?

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8664879 [details]
MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

Comment 8

[Markus Stange [:mstange]]

This patch should be better and it has an explanation of the problem in a comment. Not sure why I discarded this approach earlier.

Comment 9

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8664879 [details]
MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

https://reviewboard.mozilla.org/r/20047/#review18209

I like this a lot more too :)

Comment 10

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6765de566a32511826143c2d5c83512e83f68ab
Bug 1203190 - Don't intersect with the visible rect for fixed background images. r=mattwoodrow

Comment 11

[Markus Stange [:mstange]]

Landed with a test.

There was one remaining problem with this page which I've filed as bug 1208438.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6765de566a3