Closed Bug 1203190 Opened 6 years ago Closed 6 years ago

Laggy clip rect in some cases while scrolling with APZ on desktop

Categories

(Core :: Panning and Zooming, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: kats, Assigned: mstange)

References

()

Details

Attachments

(1 file)

smaug found an issue while scrolling on http://hiff.fi/ :

Around the middle of the page there are boxes for "INDUSTRY", "LIPUNMYYNTI", and "PRESS" - scrolling quickly up and down around these boxes, you see the images getting improperly clipped, almost like the clip rect is lagging behind.
OS: Unspecified → Mac OS X
Hardware: Unspecified → All
Version: unspecified → Trunk
That's an interesting effect. The scrolling images whose "clip" lags aren't really clipped - they're covered, by a background-attachment:fixed image that sits on top. And it's those fixed images' clip that lags. So this bug will be fixed by the remaining patches in bug 1166301.
Hmm, looks like bug 1166301 didn't actually fix this.
I'll look into this.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Bug 1203190 - Override the visible rect of background-attachment:fixed display items more aggressively. r=mattwoodrow
Attachment #8664879 - Flags: review?(matt.woodrow)
This is not the greatest patch ever... do you have any better ideas for how to fix it?
Can you explain more what the problem is?
Comment on attachment 8664879 [details]
MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow
Attachment #8664879 - Attachment description: MozReview Request: Bug 1203190 - Override the visible rect of background-attachment:fixed display items more aggressively. r=mattwoodrow → MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow
This patch should be better and it has an explanation of the problem in a comment. Not sure why I discarded this approach earlier.
Comment on attachment 8664879 [details]
MozReview Request: Bug 1203190 - Don't intersect with the visible rect for fixed background images. r?mattwoodrow

https://reviewboard.mozilla.org/r/20047/#review18209

I like this a lot more too :)
Attachment #8664879 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6765de566a32511826143c2d5c83512e83f68ab
Bug 1203190 - Don't intersect with the visible rect for fixed background images. r=mattwoodrow
Landed with a test.

There was one remaining problem with this page which I've filed as bug 1208438.
https://hg.mozilla.org/mozilla-central/rev/c6765de566a3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Blocks: 1217168
No longer blocks: 1217168
Depends on: 1217168
Blocks: 1255130
You need to log in before you can comment on or make changes to this bug.