Closed
Bug 1203287
Opened 9 years ago
Closed 9 years ago
Build errors with --enable-simulator=arm64
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: jolesen, Assigned: jolesen)
References
Details
Attachments
(1 file)
2.69 KB,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
JS doesn't build when configured with --enable-simulator=arm64. The ARM64 patch from #1169214 did not get applied, and a few other minor problems have appeared.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jolesen
Flags: needinfo?(gary)
Flags: needinfo?(choller)
This is mine if it's compileShell, however, if we're using updated m-c it should pick up the fix.
Flags: needinfo?(choller)
Comment 2•9 years ago
|
||
(In reply to Jakob Stoklund Olesen from comment #0) > The ARM64 patch from #1169214 did not get applied, and a few other minor > problems have appeared. Thanks for pointing out. Pushed it. Though there are still some issues on m-i.
Assignee | ||
Comment 3•9 years ago
|
||
- A new argument was added to a jumpWithPatch(), but arm64 wasn't updated. - Add missing 'using namespace js'. This seems to be random fallout from the way source files get unified when building arm64. - Fix a 'return = foo' typo. It seems this code was never compiled.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(gary)
Assignee | ||
Updated•9 years ago
|
Attachment #8659545 -
Flags: review?(hv1989)
Comment 4•9 years ago
|
||
Comment on attachment 8659545 [details] [diff] [review] Fix build errors in ARM64 JIT. Review of attachment 8659545 [details] [diff] [review]: ----------------------------------------------------------------- Awesome. Thanks!
Attachment #8659545 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 5•9 years ago
|
||
I only have TryServer commit access thus far.
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e668e5f2fb8a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•