room loading spinner is no longer vertically centered

RESOLVED FIXED in Firefox 43

Status

defect
P3
minor
Rank:
35
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dmose, Assigned: mancas)

Tracking

({regression})

unspecified
mozilla44
Points:
2
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

(Whiteboard: [ui bug], )

User Story

As a user, I should see the animated spinner vertically centered while waiting for rooms to load, so that it looks most visually appealing.

Acceptance criteria:

* spinner is vertically center
* spinner continues to animate

Tech checklist:

* Review these articles about vertical centering and SVG:
http://zerosixthree.se/vertical-align-anything-with-just-3-lines-of-css/
https://css-tricks.com/svg-animation-on-css-transforms/

* Pick a solution
* Quick-n-dirty possible fix: convert to PNG

Attachments

(1 attachment)

No description provided.
Severity: normal → minor
Rank: 23
User Story: (updated)
Rank: 23 → 35
Priority: P2 → P3
Whiteboard: [ui bug]
Assignee: nobody → b.mcb
Comment on attachment 8662358 [details] [diff] [review]
Bug 1203298 - Room loading spinner should be vertically centered.

Review of attachment 8662358 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good. The only thing I'd say is for the check-in comment is probably to change it to something like "Bug 1203298 - Room loading spinner should be vertically centered." or "Bug 1203298 - Vertically center the room loading spinner.". Whilst we can frequently get away with the bug title, it sounds a little strange in this case when in the context of a patch fixing it.
Attachment #8662358 - Flags: review?(standard8) → review+
Comment on attachment 8662358 [details] [diff] [review]
Bug 1203298 - Room loading spinner should be vertically centered.

Taking into account standard8 comment about the comment
Attachment #8662358 - Attachment description: Room loading spinner is now vertically centered using css transform property. → Bug 1203298 - Room loading spinner should be vertically centered.
Manuel: I pushed this for you to as I had something else to push, though we could have used the checkin-needed keyword as well.
Iteration: --- → 43.3 - Sep 21
Oh, and it'll get marked fixed when it is merged to mozilla-central.
https://hg.mozilla.org/mozilla-central/rev/865542cbbfe5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8662358 [details] [diff] [review]
Bug 1203298 - Room loading spinner should be vertically centered.

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Loading spinner looks offset, part of the work to complete the refresh.
[Describe test coverage new/current, TreeHerder]: Css only
[Risks and why]: Low, css only
[String/UUID change made/needed]: None
Attachment #8662358 - Flags: approval-mozilla-aurora?
Do you know what caused the regression? Does this affect 42 or 41 as well?
Comment on attachment 8662358 [details] [diff] [review]
Bug 1203298 - Room loading spinner should be vertically centered.

Minor css change, ok to uplift to aurora.
Attachment #8662358 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Iteration: 43.3 - Sep 21 → 44.1 - Oct 5
You need to log in before you can comment on or make changes to this bug.