Closed
Bug 1203298
Opened 9 years ago
Closed 9 years ago
room loading spinner is no longer vertically centered
Categories
(Hello (Loop) :: Client, defect, P3)
Hello (Loop)
Client
Tracking
(firefox43 fixed, firefox44 fixed)
People
(Reporter: dmosedale, Assigned: mancas)
References
()
Details
(Keywords: regression, Whiteboard: [ui bug])
User Story
As a user, I should see the animated spinner vertically centered while waiting for rooms to load, so that it looks most visually appealing. Acceptance criteria: * spinner is vertically center * spinner continues to animate Tech checklist: * Review these articles about vertical centering and SVG: http://zerosixthree.se/vertical-align-anything-with-just-3-lines-of-css/ https://css-tricks.com/svg-animation-on-css-transforms/ * Pick a solution * Quick-n-dirty possible fix: convert to PNG
Attachments
(1 file)
933 bytes,
patch
|
standard8
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•9 years ago
|
Severity: normal → minor
Rank: 23
Updated•9 years ago
|
User Story: (updated)
Updated•9 years ago
|
Rank: 23 → 35
Priority: P2 → P3
Whiteboard: [ui bug]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → b.mcb
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8662358 -
Flags: review?(standard8)
Comment 2•9 years ago
|
||
Comment on attachment 8662358 [details] [diff] [review] Bug 1203298 - Room loading spinner should be vertically centered. Review of attachment 8662358 [details] [diff] [review]: ----------------------------------------------------------------- Yep, looks good. The only thing I'd say is for the check-in comment is probably to change it to something like "Bug 1203298 - Room loading spinner should be vertically centered." or "Bug 1203298 - Vertically center the room loading spinner.". Whilst we can frequently get away with the bug title, it sounds a little strange in this case when in the context of a patch fixing it.
Attachment #8662358 -
Flags: review?(standard8) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8662358 [details] [diff] [review] Bug 1203298 - Room loading spinner should be vertically centered. Taking into account standard8 comment about the comment
Attachment #8662358 -
Attachment description: Room loading spinner is now vertically centered using css transform property. → Bug 1203298 - Room loading spinner should be vertically centered.
Comment 5•9 years ago
|
||
Manuel: I pushed this for you to as I had something else to push, though we could have used the checkin-needed keyword as well.
Iteration: --- → 43.3 - Sep 21
Comment 6•9 years ago
|
||
Oh, and it'll get marked fixed when it is merged to mozilla-central.
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/865542cbbfe5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment 8•9 years ago
|
||
Comment on attachment 8662358 [details] [diff] [review] Bug 1203298 - Room loading spinner should be vertically centered. Approval Request Comment [Feature/regressing bug #]: Hello Visual refresh [User impact if declined]: Loading spinner looks offset, part of the work to complete the refresh. [Describe test coverage new/current, TreeHerder]: Css only [Risks and why]: Low, css only [String/UUID change made/needed]: None
Attachment #8662358 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
Do you know what caused the regression? Does this affect 42 or 41 as well?
Comment 10•9 years ago
|
||
Comment on attachment 8662358 [details] [diff] [review] Bug 1203298 - Room loading spinner should be vertically centered. Minor css change, ok to uplift to aurora.
Attachment #8662358 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/c8c2cbe97fb2
status-firefox43:
--- → fixed
Updated•9 years ago
|
Iteration: 43.3 - Sep 21 → 44.1 - Oct 5
You need to log in
before you can comment on or make changes to this bug.
Description
•