1203380 - fix downstream references in AudioBlock

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Karl Tomlinson (:karlt)]

There are some bugs in AudioBlock that I didn't notice because I'd accidentally disabled most of the downstream ref behavior before review.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1203380 ClearDownstreamMark() before returning AsMutableChunk() r?padenot

bug 1203380 ClearDownstreamMark() before returning AsMutableChunk() r?padenot

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1203380 destroy AudioBlocks on AudioNodeStream on graph thread r?padenot

bug 1203380 destroy AudioBlocks on AudioNodeStream on graph thread r?padenot

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1203380 tighten not-sharing assertion in ChannelFloatsForWrite() r?padenot

bug 1203380 tighten not-sharing assertion in ChannelFloatsForWrite() r?padenot

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1203380 add custom assignment operator to AudioBlock r?padenot

bug 1203380 add custom assignment operator to AudioBlock r?padenot

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: MozReview Request: bug 1203380 add custom AudioBlock copy constructor and make AudioChunk conversion constructor explicit r?padenot

bug 1203380 add custom AudioBlock copy constructor and make AudioChunk conversion constructor explicit r?padenot

Making the conversion constructor explicit means that it will be obvious if
a temporary is created to pass an AudioChunk as an AudioBlock parameter.

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8659067 [details]
MozReview Request: bug 1203380 ClearDownstreamMark() before returning AsMutableChunk() r?padenot

https://reviewboard.mozilla.org/r/18753/#review16789

::: dom/media/webaudio/AudioBlock.h:47
(Diff revision 1)
> -    void ClearDownstreamMark();
> +    ClearDownstreamMark();

Hrm I remember seeing this on the first review but somehow my comment got lost ? It certainly isn't in the other bug.

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8659068 [details]
MozReview Request: bug 1203380 destroy AudioBlocks on AudioNodeStream on graph thread r?padenot

https://reviewboard.mozilla.org/r/18755/#review16791

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8659069 [details]
MozReview Request: bug 1203380 tighten not-sharing assertion in ChannelFloatsForWrite() r?padenot

https://reviewboard.mozilla.org/r/18757/#review16793

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8659070 [details]
MozReview Request: bug 1203380 add custom assignment operator to AudioBlock r?padenot

https://reviewboard.mozilla.org/r/18759/#review16795

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8659071 [details]
MozReview Request: bug 1203380 add custom AudioBlock copy constructor and make AudioChunk conversion constructor explicit r?padenot

https://reviewboard.mozilla.org/r/18761/#review16797

Comment 11

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3bd205b08af3

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ebbacbfa7f2
https://hg.mozilla.org/integration/mozilla-inbound/rev/6450772ee568
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1cd18b4158c
https://hg.mozilla.org/integration/mozilla-inbound/rev/0919409dd75f
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f4912c6cf47

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8ebbacbfa7f2
https://hg.mozilla.org/mozilla-central/rev/6450772ee568
https://hg.mozilla.org/mozilla-central/rev/b1cd18b4158c
https://hg.mozilla.org/mozilla-central/rev/0919409dd75f
https://hg.mozilla.org/mozilla-central/rev/3f4912c6cf47