fix downstream references in AudioBlock

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: karlt, Assigned: karlt)

Tracking

({perf})

unspecified
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(5 attachments)

There are some bugs in AudioBlock that I didn't notice because I'd accidentally disabled most of the downstream ref behavior before review.
bug 1203380 ClearDownstreamMark() before returning AsMutableChunk() r?padenot
Attachment #8659067 - Flags: review?(padenot)
bug 1203380 destroy AudioBlocks on AudioNodeStream on graph thread r?padenot
Attachment #8659068 - Flags: review?(padenot)
bug 1203380 tighten not-sharing assertion in ChannelFloatsForWrite() r?padenot
Attachment #8659069 - Flags: review?(padenot)
bug 1203380 add custom assignment operator to AudioBlock r?padenot
Attachment #8659070 - Flags: review?(padenot)
bug 1203380 add custom AudioBlock copy constructor and make AudioChunk conversion constructor explicit r?padenot

Making the conversion constructor explicit means that it will be obvious if
a temporary is created to pass an AudioChunk as an AudioBlock parameter.
Attachment #8659071 - Flags: review?(padenot)
Comment on attachment 8659067 [details]
MozReview Request: bug 1203380 ClearDownstreamMark() before returning AsMutableChunk() r?padenot

https://reviewboard.mozilla.org/r/18753/#review16789

::: dom/media/webaudio/AudioBlock.h:47
(Diff revision 1)
> -    void ClearDownstreamMark();
> +    ClearDownstreamMark();

Hrm I remember seeing this on the first review but somehow my comment got lost ? It certainly isn't in the other bug.
Attachment #8659067 - Flags: review?(padenot) → review+
Comment on attachment 8659068 [details]
MozReview Request: bug 1203380 destroy AudioBlocks on AudioNodeStream on graph thread r?padenot

https://reviewboard.mozilla.org/r/18755/#review16791
Attachment #8659068 - Flags: review?(padenot) → review+
Comment on attachment 8659069 [details]
MozReview Request: bug 1203380 tighten not-sharing assertion in ChannelFloatsForWrite() r?padenot

https://reviewboard.mozilla.org/r/18757/#review16793
Attachment #8659069 - Flags: review?(padenot) → review+
Comment on attachment 8659070 [details]
MozReview Request: bug 1203380 add custom assignment operator to AudioBlock r?padenot

https://reviewboard.mozilla.org/r/18759/#review16795
Attachment #8659070 - Flags: review?(padenot) → review+
Comment on attachment 8659071 [details]
MozReview Request: bug 1203380 add custom AudioBlock copy constructor and make AudioChunk conversion constructor explicit r?padenot

https://reviewboard.mozilla.org/r/18761/#review16797
Attachment #8659071 - Flags: review?(padenot) → review+
You need to log in before you can comment on or make changes to this bug.