Intermittent layout/reftests/scrolling/fixed-table-1.html | image comparison (==), max difference: 165, number of differing pixels: 59976

REOPENED
Unassigned

Status

()

Core
Layout
P3
normal
REOPENED
2 years ago
a year ago

People

(Reporter: nigelb, Unassigned)

Tracking

({intermittent-failure})

Trunk
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)
Comment hidden (Treeherder Robot)
[Mass Closure] Closing Intermittent as a one off
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

Comment 3

2 years ago
15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 15

Platform breakdown:
* android-4-3-armv7-api11: 14
* android-2-3-armv7-api9: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-10-30&endday=2015-10-30&tree=all

Comment 4

2 years ago
35 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 33
* mozilla-central: 2

Platform breakdown:
* android-4-3-armv7-api11: 30
* android-2-3-armv7-api9: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-10-26&endday=2015-11-01&tree=all

Comment 5

2 years ago
15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 6
* fx-team: 3
* b2g-inbound: 3
* try: 2
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api11: 12
* android-2-3-armv7-api9: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-05&endday=2015-11-05&tree=all

Comment 6

2 years ago
19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 11
* mozilla-central: 3
* fx-team: 3
* b2g-inbound: 2

Platform breakdown:
* android-4-3-armv7-api11: 15
* android-2-3-armv7-api9: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-06&endday=2015-11-06&tree=all

Comment 7

2 years ago
81 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 43
* b2g-inbound: 16
* fx-team: 12
* mozilla-central: 7
* try: 3

Platform breakdown:
* android-4-3-armv7-api11: 59
* android-2-3-armv7-api9: 22

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-02&endday=2015-11-08&tree=all

Comment 8

2 years ago
35 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 14
* mozilla-central: 8
* fx-team: 8
* b2g-inbound: 4
* try: 1

Platform breakdown:
* android-4-3-armv7-api11: 25
* android-2-3-armv7-api9: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-09&endday=2015-11-15&tree=all

Comment 9

2 years ago
33 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 14
* fx-team: 7
* mozilla-central: 5
* b2g-inbound: 5
* try: 2

Platform breakdown:
* android-4-3-armv7-api11: 25
* android-2-3-armv7-api9: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-16&endday=2015-11-22&tree=all

Comment 10

2 years ago
25 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9
* fx-team: 6
* mozilla-central: 4
* try: 3
* b2g-inbound: 3

Platform breakdown:
* android-4-3-armv7-api11: 16
* android-2-3-armv7-api9: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-23&endday=2015-11-29&tree=all

Comment 11

2 years ago
29 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* fx-team: 8
* b2g-inbound: 7
* mozilla-inbound: 6
* try: 4
* mozilla-central: 4

Platform breakdown:
* android-4-3-armv7-api11: 20
* android-2-3-armv7-api9: 9

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-11-30&endday=2015-12-06&tree=all

Comment 12

2 years ago
27 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 12
* fx-team: 7
* mozilla-central: 3
* b2g-inbound: 3
* try: 2

Platform breakdown:
* android-4-3-armv7-api11: 19
* android-2-3-armv7-api9: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-12-07&endday=2015-12-13&tree=all

Comment 13

2 years ago
20 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 10
* fx-team: 4
* try: 2
* b2g-inbound: 2
* mozilla-central: 1
* mozilla-aurora: 1

Platform breakdown:
* android-4-3-armv7-api11: 13
* android-2-3-armv7-api9: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-12-14&endday=2015-12-20&tree=all

Comment 14

2 years ago
21 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* mozilla-central: 5
* mozilla-aurora: 4
* fx-team: 4
* try: 1
* b2g-inbound: 1

Platform breakdown:
* android-4-3-armv7-api11: 15
* android-2-3-armv7-api9: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-12-21&endday=2015-12-27&tree=all

Comment 15

2 years ago
37 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 10
* mozilla-central: 9
* mozilla-aurora: 7
* fx-team: 6
* try: 3
* b2g-inbound: 2

Platform breakdown:
* android-4-3-armv7-api11: 26
* android-2-3-armv7-api9: 11

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2015-12-28&endday=2016-01-03&tree=all
Assignee: nobody → gbrown
This became more frequent recently, accounting for about 25% of Android intermittents last week.
Reftest analyzer shows the first (top, left) box is blank (all white) in the failed tests.

Comment 18

2 years ago
48 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 19
* fx-team: 7
* mozilla-central: 6
* b2g-inbound: 6
* try: 5
* mozilla-aurora: 5

Platform breakdown:
* android-4-3-armv7-api11: 32
* android-2-3-armv7-api9: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-01-04&endday=2016-01-10&tree=all

Comment 19

2 years ago
28 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 7
* mozilla-inbound: 5
* mozilla-central: 5
* fx-team: 5
* b2g-inbound: 4
* try: 2

Platform breakdown:
* android-4-3-armv7-api11: 21
* android-2-3-armv7-api9: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-01-11&endday=2016-01-17&tree=all
Sorry, I'm not making any progress here.

:roc -- Can you have a look?
Assignee: gbrown → nobody
Flags: needinfo?(roc)

Comment 21

2 years ago
28 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 13
* mozilla-aurora: 6
* b2g-inbound: 4
* try: 2
* mozilla-central: 2
* fx-team: 1

Platform breakdown:
* android-4-3-armv7-api11: 20
* android-2-3-armv7-api9: 7
* b2g-emu-ics: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-01-18&endday=2016-01-24&tree=all

Comment 22

2 years ago
27 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 14
* mozilla-aurora: 5
* mozilla-central: 3
* fx-team: 3
* try: 2

Platform breakdown:
* android-4-3-armv7-api15: 10
* android-4-3-armv7-api11: 10
* android-2-3-armv7-api9: 5
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-01-25&endday=2016-01-31&tree=all

Comment 23

2 years ago
37 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 15
* fx-team: 6
* mozilla-beta: 5
* mozilla-aurora: 5
* try: 3
* mozilla-central: 3

Platform breakdown:
* android-4-3-armv7-api15: 26
* android-2-3-armv7-api9: 6
* android-4-3-armv7-api11: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-02-01&endday=2016-02-07&tree=all
I have reproduced this in rr chaos mode! \o/
Flags: needinfo?(roc)
The test fails because the first table's background image hasn't finished loading. At least, we receive the FRAME_UPDATE and FRAME_COMPLETE notifications after the reftest paints.
What happens here is that we try to paint the nsDisplayTableBackground before the image is fully loaded, without sync image decoding, and that sets its geometry's mLastDrawResult to BAD_IMAGE, which is wrong. It's set to BAD_IMAGE because nsTablePainter unconditionally calls nsCSSRendering::PaintBackgroundWithSC for various table parts such as col-groups, which have a default nsStyleBackground and nsStyleImageLayers; nsStyleImageLayers always constructs a single Layer of type eStyleImageType_Null (for reasons I do not know), and nsCSSRendering::PaintBackgroundWithSC tries to paint that layer, which ends up returning BAD_IMAGE. My fix for this bug is to make PaintBackgroundWithSC just skip layers of type eStyleImageType_Null.

For the record, after mLastDrawResult has been set to BAD_IMAGE, we later do a reftest paint with sync image decoding. nsDisplayTableItem::ComputeInvalidationRegion should invalidate the image due to aBuilder->ShouldSyncDecodeImages() && geometry->ShouldInvalidateToSyncDecodeImages(), but the latter is false because of mDrawResult being BAD_IMAGE. So we don't invalidate, and the table background isn't repainted at all.

There's another bug here I'm not fixing, which is that you could contrive a testcase where an image for a table part (e.g. a col-group) fails to load, causing BAD_IMAGE being stored for the entire nsDisplayTableBackground, which means we'd hit this same bug again. The underlying problem there is that nsDisplayTableBackground loads many images but we only store BAD_IMAGE for one image, so one bad image can cause us to skip invalidation for images that should still be sync-decoded.
Ah, there's another bug in TableBackgroundPainter::PaintTable: the result of PaintTableFrame is discarded. That also needs to be fixed to prevent this bug.
Created attachment 8718981 [details]
MozReview Request: Bug 1203417. Don't report BAD_IMAGE failure when trying to paint a null image. r=seth

Review commit: https://reviewboard.mozilla.org/r/34821/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34821/
Attachment #8718981 - Flags: review?(seth)
Created attachment 8718982 [details]
MozReview Request: Bug 1203417. Propagate error result from PaintTableFrame. r=seth

Review commit: https://reviewboard.mozilla.org/r/34823/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34823/
Attachment #8718982 - Flags: review?(seth)

Comment 30

2 years ago
32 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 13
* mozilla-inbound: 9
* mozilla-beta: 3
* fx-team: 3
* try: 2
* mozilla-central: 2

Platform breakdown:
* android-4-3-armv7-api15: 18
* android-2-3-armv7-api9: 12
* android-4-3-armv7-api11: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-02-08&endday=2016-02-14&tree=all
Comment on attachment 8718981 [details]
MozReview Request: Bug 1203417. Don't report BAD_IMAGE failure when trying to paint a null image. r=seth

https://reviewboard.mozilla.org/r/34821/#review33277

::: layout/base/nsCSSRendering.cpp:3007
(Diff revision 1)
> +        // XXX why does nsStyleImageLayers always allocate an empty Layer?

Yeah, it's worth thinking about this at some point. The problem with *not* reporting a null image as BAD_IMAGE is that otherwise, if the image remains null, we'll keep trying to paint it over and over and sync decoding for reftest snapshots will get stuck in an infinite loop. Basically the code as written now expects that an image being null is a permanent state, and apparently that's not the case...
Attachment #8718981 - Flags: review?(seth) → review+
Attachment #8718982 - Flags: review?(seth) → review+
Comment on attachment 8718982 [details]
MozReview Request: Bug 1203417. Propagate error result from PaintTableFrame. r=seth

https://reviewboard.mozilla.org/r/34823/#review33279
(In reply to Seth Fowler [:seth] [:s2h] from comment #31)
> Yeah, it's worth thinking about this at some point. The problem with *not*
> reporting a null image as BAD_IMAGE is that otherwise, if the image remains
> null, we'll keep trying to paint it over and over and sync decoding for
> reftest snapshots will get stuck in an infinite loop. Basically the code as
> written now expects that an image being null is a permanent state, and
> apparently that's not the case...

No. See comment #26; in this case null is a permanent state. The problem is that we're merging the results of painting a table background which is not null and loading with a col-group background which is null, to get BAD_IMAGE, which makes us fail to invalidate when the table background finishes loading.

> The problem with *not* reporting a null image as BAD_IMAGE is that otherwise, if the image remains null, we'll keep trying
> to paint it over and over and sync decoding for reftest snapshots will get stuck in an infinite loop.

In that case, perhaps this patch is incorrect ... but I don't see this behavior. For a null image we return SUCCESS, so why would we try to paint it over and over?
Flags: needinfo?(seth)

Comment 34

2 years ago
33 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9
* fx-team: 9
* mozilla-aurora: 6
* mozilla-central: 4
* mozilla-beta: 3
* try: 2

Platform breakdown:
* android-4-3-armv7-api15: 25
* android-2-3-armv7-api9: 6
* android-4-3-armv7-api11: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-02-22&endday=2016-02-28&tree=all
Flags: needinfo?(seth)

Comment 35

2 years ago
51 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 16
* mozilla-aurora: 13
* fx-team: 9
* mozilla-central: 7
* try: 4
* mozilla-beta: 2

Platform breakdown:
* android-4-3-armv7-api15: 36
* android-2-3-armv7-api9: 13
* windows7-32: 1
* android-4-3-armv7-api11: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-02-29&endday=2016-03-06&tree=all
Keywords: leave-open

Comment 36

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f0d53575f39

Comment 37

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f0d53575f39
23 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 6
* fx-team: 6
* mozilla-aurora: 5
* try: 4
* mozilla-beta: 2

Platform breakdown:
* android-4-3-armv7-api15: 18
* android-2-3-armv7-api9: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-03-07&endday=2016-03-13&tree=all
21 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 10
* mozilla-aurora: 10
* mozilla-release: 1

Platform breakdown:
* android-4-3-armv7-api15: 17
* android-2-3-armv7-api9: 2
* windows7-32: 1
* android-4-3-armv7-api11: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-03-14&endday=2016-03-20&tree=all
8 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 4
* mozilla-aurora: 4

Platform breakdown:
* android-4-3-armv7-api15: 6
* android-2-3-armv7-api9: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-03-21&endday=2016-03-27&tree=all
13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 6
* mozilla-beta: 5
* try: 1
* mozilla-release: 1

Platform breakdown:
* android-4-3-armv7-api15: 10
* android-2-3-armv7-api9: 2
* android-4-3-armv7-api11: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-03-28&endday=2016-04-03&tree=all
Keywords: leave-open
13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 8
* mozilla-beta: 4
* mozilla-release: 1

Platform breakdown:
* android-4-3-armv7-api15: 11
* android-2-3-armv7-api9: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-04-04&endday=2016-04-10&tree=all
6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 5
* mozilla-beta: 1

Platform breakdown:
* android-4-3-armv7-api15: 4
* android-2-3-armv7-api9: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-04-11&endday=2016-04-17&tree=all
21 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 15
* mozilla-release: 4
* mozilla-beta: 2

Platform breakdown:
* android-4-3-armv7-api15: 14
* android-2-3-armv7-api9: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-04-18&endday=2016-04-24&tree=all
6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 5
* mozilla-release: 1

Platform breakdown:
* android-4-3-armv7-api15: 4
* android-2-3-armv7-api9: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1203417&startday=2016-05-10&endday=2016-05-16&tree=all

Comment 46

a year ago
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.