1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Splitting into smaller tests may help to prevent the intermittent script timed out [1]. And this also benefits bug 1079880.

[1] https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=3f885f145ffd&exclusion_profile=false&filter-searchStr=mnw

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: MozReview Request: Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests. r=bevis

Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Try runs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa8c4eb2aab1&exclusion_profile=false

Comment 3

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8659100 [details]
MozReview Request: Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests. r=bevis

Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

https://reviewboard.mozilla.org/r/18763/#review16867

Looks good to me.
Thanks!

::: dom/cellbroadcast/tests/marionette/head.js:207
(Diff revision 1)
> -    cbManager = window.navigator.mozCellBroadcast;
> +    // Permission changes can't change existing Navigator.prototype

Thanks for adding this.

::: dom/cellbroadcast/tests/marionette/head.js:221
(Diff revision 1)
> -    if (cbManager instanceof window.MozCellBroadcast) {
> +      if (cbManager instanceof MozCellBroadcast) {

nit: it seems not necessary to make this change.

Comment 5

[Bevis Tseng[:bevis][:btseng](Exited)]

https://reviewboard.mozilla.org/r/18763/#review16869

Looks good to me.
Thanks!

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8659100 [details]
MozReview Request: Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests. r=bevis

https://reviewboard.mozilla.org/r/18765/#review16871

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8659100 [details]
MozReview Request: Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests. r=bevis

Bug 1203425 - [Cellbroadcast] Split test_cellbroadcast_{gsm|umts}.js into smaller tests. r=bevis

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f3ce28ac55cf

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3ce28ac55cf