1203508 - Ensure all strings are landed for desktop bookmark UI

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Richard Newman [:rnewman]]

This *should* be as simple as "Desktop Bookmarks". This bug is to make sure anything we need is landed by 1.1 string freeze.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

I think this is all we need. The names for the other folders are already in our tree, but in any case also arrive as part of the Sync records.

Robin: if there's anything you think we need here -- "Not yet synced", some indication of read-only, anything -- please let me know.

Comment 2

[Darrin Henein [:darrin]]

Comment on attachment 8660946 [details] [review]
Pull req.

Looks great for now, let's address the accuracy of "Desktop Bookmarks" later on... ;)

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8660946 [details] [review]
Pull req.

https://github.com/mozilla/firefox-ios/commit/a223c111734b5593d26852d43de25892cbf22693

4:28 PM <darrin> do we use “Desktop” on android?
4:27 PM <@rnewman> yes, same string
4:27 PM <@rnewman> it's not technically accurate, but it's close enough
4:28 PM <darrin> rnewman: my only concern was bookmarks from other non-desktop devices (tablets, etc)
4:28 PM <@rnewman> aye
4:28 PM <darrin> vs “Other Bookmarks”… but thats kinda ambiguous too
4:28 PM <@rnewman> right now those won't be uploaded unless they're Android or desktop, mind
4:28 PM <@rnewman> Synced Bookmarks isn't quite right either; only Non-Mobile Bookmarks would be accurate, and that sucks
4:28 PM <darrin> truth
4:28 PM <@rnewman> so we just shrugged and went for it :)
4:28 PM <darrin> Desktop Bookmarks for now then, show me where to sign
4:29 PM <darrin> we can address this in whole later on