Closed Bug 1203524 Opened 4 years ago Closed 4 years ago

search.xml should use Services.jsm

Categories

(Firefox :: Search, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

While reviewing the search.xml file to verify I haven't left any dead code behind while working on bug 1119250, I noticed that using Services.jsm could significantly simplify some of the remaining code.
Attached patch PatchSplinter Review
Attachment #8659245 - Flags: review?(dtownsend)
Attachment #8659245 - Flags: review?(dtownsend) → review+
Backing out Bug 1184220 wasn't enough to fix the bustage, apparently, so I'm backing out everything else from that push to hopefully get back to a clean slate.
https://hg.mozilla.org/integration/fx-team/rev/7ae566736bc0
https://hg.mozilla.org/mozilla-central/rev/e4e04ee24e49
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.