Closed
Bug 1203566
Opened 9 years ago
Closed 9 years ago
Add some packages to the new desktop-build to support building OS X cross-tools
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: ted, Assigned: ted)
Details
Attachments
(3 files)
I've been using desktop-build to build some of the tools that the cross-mac builds need (cctools, libdmg-hfsplus), but trying to rebuild them with the new CentOS 6 desktop-build showed that I was missing a few packages. dustin and I chatted briefly about this on IRC and he suggested that if it was just a few packages we might as well just add them to desktop-build to limit the number of images we have around.
Assignee | ||
Comment 1•9 years ago
|
||
bug 1203566 - Add some packages to centos6-build for building cross-mac tools. r?dustin
Attachment #8659294 -
Flags: review?(dustin)
Comment 2•9 years ago
|
||
Comment on attachment 8659294 [details]
MozReview Request: bug 1203566 - Add some packages to centos6-build for building cross-mac tools. r?dustin
https://reviewboard.mozilla.org/r/18785/#review16813
Let me know if you need me to rebuild and upload these (before landing)
Attachment #8659294 -
Flags: review?(dustin) → review+
Comment 3•9 years ago
|
||
push'd (well, pushing, but by the time you read this...)
Comment 4•9 years ago
|
||
bug 1203566 - Add some packages to centos6-build for building cross-mac tools. r?dustin
Comment 5•9 years ago
|
||
Bug 1203158: add a centos6-build-upd layer to include frequent yum updates; r?ted.mielczarek
Attachment #8659560 -
Flags: review?(ted)
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8659560 [details]
MozReview Request: Bug 1203158: add a centos6-build-upd layer to include frequent yum updates; r?ted.mielczarek
https://reviewboard.mozilla.org/r/18945/#review16891
Looks good with just one question.
::: testing/docker/centos6-build-upd/Dockerfile:1
(Diff revision 1)
> +FROM taskcluster/centos6-build:0.0.2
You say _layer_ but you've broken it out into a separate image. I'm not completely conversant in Docker terminology, but those are separate things, right? Is there a reason to prefer this over just putting `yum update` in a separate `RUN` in the centos6-build Dockerfile?
Attachment #8659560 -
Flags: review?(ted) → review+
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
I think you understand images and layers correctly. The difference here is that all of the layers in a single Dockerfile are regenerated at once (we use `docker build --no-cache` since docker doesn't really "get" that `yum update` may not do the same thing today that it did yesterday). Anyway, the idea is that we can run (cd testing/docker; ./build.sh centos6-build-upd && ./build.sh desktop-build) after bumping version numbers and get a new yum-update layer without touching the big centos6-build layer (and thus not requiring people to download those bits again). Thanks for the review and landing!
Assignee | ||
Comment 10•9 years ago
|
||
Aha, I didn't know about the usage of --no-cache (but that makes sense, Docker's caching is seriously weird).
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•