1203584 - Turn off signing requirements in Firefox 41 and 42

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

We've decided to push turning the pref for signing requirements on out to 43 so need to turn it off in aurora/beta. Forcing the pref on will be pushed out to 44.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

As a simple pref change I'm going to assert that we don't need a review here, we also don't want to take this change on nightly so this just needs to land straight to aurora/beta

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8659315 [details] [diff] [review]
patch

Requiring add-ons to be signed by default is turned off for 41 and 42. Let's uplift to Beta41 and Aurora42.

Comment 3

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f11f7872e219
https://hg.mozilla.org/releases/mozilla-beta/rev/7e089d707196

Comment 4

[Florin Mezei, QA (:FlorinMezei)]

Assigning to Vasilica for a quick check that this properly disabled.

Comment 5

[Vasilica Tamas, QA [:vtamas]]

I can confirm that xpinstall.signatures.required pref is set to false by default in Firefox 42.0a2 (2015-09-11) and Firefox 41 Beta 9 (20150910171927) under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.

Also performed a brief check to ensure that no new issue were caused by this changing.

Comment 7

[(Away)]

Although this was a "simple pref change", any problems between old addons and the v41 codebase are only just now coming to light, as we build the release candidate (see bug 1204324). I'm worried there may be more issues that we haven't discovered yet. It would have been nice to have longer bake time on this.