Closed Bug 1203624 Opened 4 years ago Closed 4 years ago

Measure usage of external view source

Categories

(Toolkit :: View Source, defect)

43 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

Measure usage of displaying view source in an external editor.

If low, we may remove it.  If high, we should improve it for e10s.
Jeff's thoughts from bug 1203624 comment 12:

> I wish I had a better idea of how many users have this pref set. I *think*
> it's small? It's certainly hard enough to find and finicky enough to get set
> up properly.
> 
> * measure usage and values of these two prefs in the meantime, in nightly,
> DE and Beta: "view_source.editor.external", "view_source.editor.path"
Jeff, I think I'll skip collecting "view_source.editor.path", is that okay?  It's a full file path string, so there could many combinations, and I'm not sure Telemetry is a great way to capture that data.
Flags: needinfo?(jgriffiths)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Jeff, I think I'll skip collecting "view_source.editor.path", is that okay? 
> It's a full file path string, so there could many combinations, and I'm not
> sure Telemetry is a great way to capture that data.

Agreed.
Flags: needinfo?(jgriffiths)
:mconley flagged for review, :ally for privacy review on new telemetry probes.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8661002 - Flags: review?(mconley)
Attachment #8661002 - Flags: feedback?(ally)
Comment on attachment 8661002 [details] [diff] [review]
view-source-external-usage

Review of attachment 8661002 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks jryans!
Attachment #8661002 - Flags: review?(mconley) → review+
Comment on attachment 8661002 [details] [diff] [review]
view-source-external-usage

Review of attachment 8661002 [details] [diff] [review]:
-----------------------------------------------------------------

Update the expires_in_version to 50-55. I think 50ish should be enough time to get a sense of usage of this feature.

p=ally with those changes

::: toolkit/components/telemetry/Histograms.json
@@ +7317,5 @@
>      "n_buckets": 20,
>      "description": "The amount of time spent in a specific performance tool view, keyed by view name (waterfall, js-calltree, js-flamegraph, etc)."
>    },
> +  "VIEW_SOURCE_IN_BROWSER_OPENED_BOOLEAN": {
> +    "expires_in_version": "never",

We no longer allow "never" for expiration. How about version 50?
Attachment #8661002 - Flags: feedback?(ally) → review+
Okay, pinned expire to 53 and added alert emails to be notified of expiration.
https://hg.mozilla.org/mozilla-central/rev/a88abc5e76ed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1207629
Looking across two weeks of Dev. Ed 43 data:

View Source in Browser[1]:         56,700 uses (99.30%)
View Source in Window[2]:             357 uses ( 0.62%)
View Source External (Success)[3]:     44 uses ( 0.08%)
View Source External (Failed)[3]:      48 uses (re-counted as browser / window above)

Jeff, any thoughts on view source in external editor from this data, or too soon to tell?

[1]: http://is.gd/BkM5Q0
[2]: http://is.gd/u4kKdb
[3]: http://is.gd/1kU9iW
Flags: needinfo?(jgriffiths)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #11)
> Looking across two weeks of Dev. Ed 43 data:
> 
> View Source in Browser[1]:         56,700 uses (99.30%)
> View Source in Window[2]:             357 uses ( 0.62%)
> View Source External (Success)[3]:     44 uses ( 0.08%)
> View Source External (Failed)[3]:      48 uses (re-counted as browser /
> window above)
> 
> Jeff, any thoughts on view source in external editor from this data, or too
> soon to tell?
> 
> [1]: http://is.gd/BkM5Q0
> [2]: http://is.gd/u4kKdb
> [3]: http://is.gd/1kU9iW

That's a pretty high fairly rate and really low usage :(

Let's let it run for another couple of weeks and see if there is variance.
Flags: needinfo?(jgriffiths)
(In reply to Jeff Griffiths (:canuckistani) (:⚡︎) from comment #12)
> That's a pretty high fairly rate

Just to be clear about what "failure" means here:

* it means view source external was enabled, but it did not work for some reason
* my most likely guess is that the external program defined no longer exists, or the argument passed to it triggered an error, but we have no data to know for sure
* in any event, we fall back to some other view source mode, so the source will always be shown, but just not in the external program in case of failure

In some ways, I could imagine more people liking this feature if it were more discoverable.  If we had a better story for general external tool integration with DevTools, this could be one small part of that story.
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #13)
...
> In some ways, I could imagine more people liking this feature if it were
> more discoverable.  If we had a better story for general external tool
> integration with DevTools, this could be one small part of that story.

Absolutely - having a way to launch a file picker that correctly chooses an application and escapes the path to it would be a good start. I suspect a lot of failures are just from people manually entering a path that doesn't work into about:config.
You need to log in before you can comment on or make changes to this bug.