1203786 - test_memoryReporters.xul sensitive to namespaces

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

test_memoryReporters.xul's check for http URLs in anonymized mode does not account for xmlns="" attributes in windows, which presumably are safe to allow.

As an example of this, run:

mach mochitest -f chrome docshell/test/chrome/test_principalInherit.xul toolkit/components/aboutmemory/tests/test_memoryReporters.xul

This gives:

87 INFO TEST-UNEXPECTED-FAIL | toolkit/components/aboutmemory/tests/test_memoryReporters.xul | http URLs are anonymized when necessary. Failed case: explicit/window-objects/top(none)/detached/window(data:application\vnd.mozilla.xul+xml,<?xml%20version="1.0"?><window%20xmlns="http:\\www.mozilla.org\keymaster\gatekeeper\there.is.only.xul"\>)/js-compartment([System Principal], about:blank)/sundries/malloc-heap
@chrome://mochitests/content/chrome/toolkit/components/aboutmemory/tests/test_memoryReporters.xul:248:1

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c56f273184a4

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 8659642 [details]
MozReview Request: Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

https://reviewboard.mozilla.org/r/18995/#review16857

::: toolkit/components/aboutmemory/tests/test_memoryReporters.xul:42
(Diff revision 1)
> +  // For some reason, the slashes are printed backwards here.

The memory reporters use '/' as a path separator so we have hack where we flip all slashes in URLs. Gross, I know.

So you can change the comment to something like "Use backslashes instead of forward slashes due to memory reporting's hacky handling of URLs".

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8659642 [details]
MozReview Request: Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

https://reviewboard.mozilla.org/r/18995/#review16859

Comment 5

[Nicholas Nethercote [inactive]]

BTW, this is my first review using MozReview. Hopefully I've done the right thing. In a Bugzilla review I would give you r+ here, but ask you to fix the one nit before landing.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> BTW, this is my first review using MozReview. Hopefully I've done the right
> thing. In a Bugzilla review I would give you r+ here, but ask you to fix the
> one nit before landing.

Seems like it mostly worked as you meant it to!  For the future, it should let you submit your comments and the "ship it" in one step, just like an r+ with comments to fix in Bugzilla.  The UI isn't super obvious about it though, takes a bit of trying!

Thanks for the quick review!

Comment 7

[Nicholas Nethercote [inactive]]

> For the future, it should
> let you submit your comments and the "ship it" in one step, just like an r+
> with comments to fix in Bugzilla.

Right, I saw the checkbox but wasn't sure if that would autoland it, so I erred on the safe side. And then glandium told me it wouldn't autoland, so I checked it afterward :)

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8659642 [details]
MozReview Request: Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

Bug 1203786 - test_memoryReporters.xul should ignore namespaces. r=njn

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I've updated the comments, and try looks good.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6be981250868

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6be981250868