Closed Bug 1203796 Opened 4 years ago Closed 4 years ago

./mach try doesn't remove the trychooser commit if git push fails

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: ehsan, Unassigned)

References

Details

Attachments

(1 file)

$ ./mach try -b o -p linux64-st-an -u none
mach try is under development, please file bugs blocking 1149670.
[linux64-st-an-opt 16d5627] try: -b o -p linux64-st-an -u none -t none
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 6 changesets with 2 changes to 683 files (+1 heads)
remote:
remote:
remote: ************************** ERROR ****************************
remote: try is CLOSED! Reason: gitmo overload
remote: To push despite the closed tree, include "CLOSED TREE" in your push comment
remote: *************************************************************
remote:
remote:
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.a_treeclosure hook failed
To hg::ssh://hg.mozilla.org/try
 ! [remote rejected] HEAD -> branches/default/tip (nothing changed on remote)
error: failed to push some refs to 'hg::ssh://hg.mozilla.org/try'
ERROR git command ['git', 'push', 'hg::ssh://hg.mozilla.org/try', '+HEAD:refs/heads/branches/default/tip'] returned 1
$ git show
commit 16d5627149612d037cd436204f7ee5fd908ce254 (HEAD -> linux64-st-an-opt)
Author: Ehsan Akhgari <ehsan@mozilla.com>
Date:   Thu Sep 10 17:54:52 2015 -0400

    try: -b o -p linux64-st-an -u none -t none
Comment on attachment 8659649 [details] [diff] [review]
Remove the trychooser syntax commit if pushing to the try server fails

Review of attachment 8659649 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.
Attachment #8659649 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/4c42d55c2455
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.