1203809 - pass gfxTextPerfMetrics object into CreateFontGroup constructor

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[John Daggett (:jtd)]

The gfxTextPerfMetrics object is set on font groups after they are constructed. For example, within nsFontMetrics::Init:

  mFontGroup = gfxPlatform::GetPlatform()->
    CreateFontGroup(aFont.fontlist, &style, aUserFontSet);
  mFontGroup->SetTextPerfMetrics(aTextPerf);

This means that any statistic related to fontlist initialization within the gfxFontGroup constructor can't be included because it's not initialized yet.

I think it would make sense to simply initialize gfxFontGroup with this and avoid the awkward "initialize after construction" step.

Comment 1

[John Daggett (:jtd)]

Attachment: patch, pass in gfxTextPerfMetrics object

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f290d4c9fbb

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f290d4c9fbb