1203829 - Add more compositor support for mix-blend modes

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: support all blend modes in the basic compositor

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: use newer fxc

The FXC used in the tree is from 2009, and reports as version "9.29". The compiler in the latest Windows SDK is from 2013, and reports as version "6.3".

I don't know what to make of that, but Matt suggested using the newer-dated version, so I ran it once before changing shaders on top of it.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: refactor shader init

The way shaders are initialized makes it pretty verbose to add new shaders. This is a little refactoring to make it easier.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: MULTIPLY and SCREEN support for d3d11

Add support for OP_MULTIPLY and OP_SCREEN blend modes in CompositorD3D11. (Most of this diff is the new shader bytecode.)

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8659723 [details] [diff] [review]
MULTIPLY and SCREEN support for d3d11

Review of attachment 8659723 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d11/CompositorD3D11.cpp
@@ +620,3 @@
>  
>  void
>  CompositorD3D11::SetPSForEffect(Effect* aEffect, MaskType aMaskType, gfx::SurfaceFormat aFormat)

Comment about how RENDER_TARGET/RGB are handled later on.

@@ +628,1 @@
>      mContext->PSSetShader(mAttachments->mRGBAShader[aMaskType], nullptr, 0);

This is unreachable and should be removed, right?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60ed4fafa41e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac89d8222e1b
https://hg.mozilla.org/integration/mozilla-inbound/rev/df2be5ad917b

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c76ccb113197

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60ed4fafa41e
https://hg.mozilla.org/mozilla-central/rev/ac89d8222e1b
https://hg.mozilla.org/mozilla-central/rev/df2be5ad917b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c76ccb113197