Closed
Bug 1203835
Opened 10 years ago
Closed 10 years ago
Don't ship replace_jemalloc
Categories
(Core :: Memory Allocator, defect)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
|
3.04 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
The idea is to essentially back out bug 1014300 for multiple reasons:
- With jemalloc 4 enabled, it's not built anymore
- If we ever disable jemalloc 4 to switch back to mozjemalloc, OS X build would break because of the asymmetry between x86 and x64 (we recently switched things on OS X builds that would cause this breakage)
- If we do the above temporarily, shipping replace_jemalloc is not very useful anyways.
- If we do the above permanently, shipping replace_jemalloc is not really going to achieve much.
| Assignee | ||
Comment 1•10 years ago
|
||
Also, replace_jemalloc is the only replace malloc library with DMD that is being shipped. DMD has real usefulness. People who want to use replace_jemalloc with a nightly can still pick it from a local build, like other replace malloc libraries.
| Assignee | ||
Comment 2•10 years ago
|
||
See rationale in comment 0 and 1.
Assignee: nobody → mh+mozilla
Attachment #8659727 -
Flags: review?(n.nethercote)
Comment 3•10 years ago
|
||
Comment on attachment 8659727 [details] [diff] [review]
Don't ship replace_jemalloc
Review of attachment 8659727 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #8659727 -
Flags: review?(n.nethercote) → review+
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•