Allow to build standalone js against jemalloc4

RESOLVED FIXED in Firefox 43

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla43
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8659765 [details] [diff] [review]
Allow to build standalone js against jemalloc4
Assignee: nobody → mh+mozilla
Attachment #8659765 - Flags: review?(gps)

Comment 2

3 years ago
Comment on attachment 8659765 [details] [diff] [review]
Allow to build standalone js against jemalloc4

Review of attachment 8659765 [details] [diff] [review]:
-----------------------------------------------------------------

I assume the m4 foo was copied with the exception of the top-level conditional checking for a JS build.

Also, isn't that top-level conditional always true?
Attachment #8659765 - Flags: review?(gps) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Gregory Szorc [:gps] from comment #2)
> Also, isn't that top-level conditional always true?

It's not, that the point. That skips jemalloc configure when running js's configure during a firefox build, but not during a js standalone build.
https://hg.mozilla.org/mozilla-central/rev/f4c221a95b36
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.