STR: mochitests test_playback.html with file huge-id3.mp3, the last 2 audio sample's timestamp are wrong. See the L code: http://androidxref.com/5.1.1_r6/xref/frameworks/av/media/libstagefright/codecs/mp3dec/SoftMP3.cpp I have tried to copy the function |SoftMP3::onQueueFilled| to the emulator-kk codebase, it works.
Comment on attachment 8660575 [details] [review] merge SoftMP3::onQueueFilled from L code base I want to uplift the SoftMP3::onQueueFilled function from L to our emulator-kk code base. Current SoftMP3::onQueueFilled on emulator-kk doesn't handle the EOS well. When it receive the EOS from input, it just output the EOS to our decoder. There still some frames in the software decoder. L had fixed this by adding flags |mSawInputEos| and |mSignalledOutputEos| to retrieve the remain decoded samples when receive EOS from input. I had verified this on my emulator-kk build, it works.
Attachment #8660575 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8660575 [details] [review] merge SoftMP3::onQueueFilled from L code base Nice! Looks good.
Attachment #8660575 - Flags: review?(sotaro.ikeda.g) → review+
Please help to check-in the pull request.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.