mp3 decoded sample with timestamp reorder on emulator-kk.

RESOLVED FIXED in FxOS-S8 (02Oct)

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bechen, Assigned: bechen)

Tracking

Trunk
FxOS-S8 (02Oct)
Unspecified
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(firefox43 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
STR: 
mochitests test_playback.html with file huge-id3.mp3, the last 2 audio sample's timestamp are wrong.

See the L code:
http://androidxref.com/5.1.1_r6/xref/frameworks/av/media/libstagefright/codecs/mp3dec/SoftMP3.cpp

I have tried to copy the function |SoftMP3::onQueueFilled| to the emulator-kk codebase, it works.
(Assignee)

Comment 1

3 years ago
Created attachment 8660575 [details] [review]
merge SoftMP3::onQueueFilled from L code base
(Assignee)

Comment 2

3 years ago
Comment on attachment 8660575 [details] [review]
merge SoftMP3::onQueueFilled from L code base

I want to uplift the SoftMP3::onQueueFilled function from L to our emulator-kk code base.

Current SoftMP3::onQueueFilled on emulator-kk doesn't handle the EOS well. When it receive the EOS from input, it just output the EOS to our decoder. There still some frames in the software decoder.

L had fixed this by adding flags |mSawInputEos| and |mSignalledOutputEos| to retrieve the remain decoded samples when receive EOS from input.

I had verified this on my emulator-kk build, it works.
Attachment #8660575 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8660575 [details] [review]
merge SoftMP3::onQueueFilled from L code base

Nice! Looks good.
Attachment #8660575 - Flags: review?(sotaro.ikeda.g) → review+
(Assignee)

Comment 4

3 years ago
Please help to check-in the pull request.
Keywords: checkin-needed
https://github.com/mozilla-b2g/platform_frameworks_av/commit/2da3a2d5100f8afa1229bb50aa2a29ea0aaf8417
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.