120402 - pref for 'browsewithcaret' doesn't work in XHTML/XML documents

Status: RESOLVED DUPLICATE of bug 114440

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[rbs]

If you set the pref:
user_pref("accessibility.browsewithcaret", true);

This only works in vanilla HTML. So documents in XHTML/XML don't show the caret.

The problem is that the code that set the caret based on that pref is excluding 
non-HTML documents:

nsEventStateManager::PreHandleEvent()
[...]
    // Set mBrowseWithCaret to value of preference if we're in HTML (don't use 
caret in XUL)
    if (mDocument) {
      mBrowseWithCaret = PR_FALSE;
      nsCOMPtr<nsIHTMLDocument> htmlDoc(do_QueryInterface(mDocument));
      if (htmlDoc)
        mPrefService->GetBoolPref("accessibility.browsewithcaret", 
&mBrowseWithCaret);
    }
[...]
}

Comment 1

[rbs]

Also browsing with the pref on ends up causing a crash on a null pointer here:

nsEventStateManager::GetCaretLocation()
[...]
  nsIFrame *primaryFrame = nsnull;
  if (selectionContent) 
    rv = shell->GetPrimaryFrameFor(selectionContent, &primaryFrame);

  *aCaretFrame = primaryFrame;
  *aCaretContent = selectionContent;
  NS_ADDREF(*aCaretContent);             <===========================CRASH

  return rv;
}

The test |if (selectionContent)| implies that it can be null. And this suggests 
that the whole chunk of code is meant to be in |if (selectionContent) { ... }|.

Comment 2

[joki (gone)]

*** This bug has been marked as a duplicate of 114440 ***