1204035 - Clicking on a network message in the browser console results in TypeError: toolbox is undefined

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The browser console has no toolbox and shouldn't be displaying network requests from tabs anyway, but at least let's make sure it doesn't throw.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v1

Simple fix.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8659995 [details] [diff] [review]
Patch v1

Review of attachment 8659995 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/webconsole.js
@@ +1976,1 @@
>      let toolbox = gDevTools.getToolbox(this.owner.target);

Drive-by: could you instead check if toolbox is null and return in that case?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Sure.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8660006 [details] [diff] [review]
Patch v2

Review of attachment 8660006 [details] [diff] [review]:
-----------------------------------------------------------------

seems fine, the browser toolbox will still work for jumping to the netmonitor if needed

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9ad4faa76255

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ad4faa76255