Closed
Bug 1204035
Opened 9 years ago
Closed 9 years ago
Clicking on a network message in the browser console results in TypeError: toolbox is undefined
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file, 1 obsolete file)
1.01 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
The browser console has no toolbox and shouldn't be displaying network requests from tabs anyway, but at least let's make sure it doesn't throw.
Assignee | ||
Comment 1•9 years ago
|
||
Simple fix.
Assignee | ||
Updated•9 years ago
|
Attachment #8659995 -
Flags: review?(vporof)
Comment 2•9 years ago
|
||
Comment on attachment 8659995 [details] [diff] [review]
Patch v1
Review of attachment 8659995 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/webconsole/webconsole.js
@@ +1976,1 @@
> let toolbox = gDevTools.getToolbox(this.owner.target);
Drive-by: could you instead check if toolbox is null and return in that case?
Assignee | ||
Comment 3•9 years ago
|
||
Sure.
Attachment #8659995 -
Attachment is obsolete: true
Attachment #8659995 -
Flags: review?(vporof)
Assignee | ||
Updated•9 years ago
|
Attachment #8660006 -
Flags: review?(bgrinstead)
Comment 4•9 years ago
|
||
Comment on attachment 8660006 [details] [diff] [review]
Patch v2
Review of attachment 8660006 [details] [diff] [review]:
-----------------------------------------------------------------
seems fine, the browser toolbox will still work for jumping to the netmonitor if needed
Attachment #8660006 -
Flags: review?(bgrinstead) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•