Clicking on a network message in the browser console results in TypeError: toolbox is undefined

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
11 months ago

People

(Reporter: past, Assigned: past)

Tracking

unspecified
Firefox 43
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The browser console has no toolbox and shouldn't be displaying network requests from tabs anyway, but at least let's make sure it doesn't throw.
Posted patch Patch v1 (obsolete) — Splinter Review
Simple fix.
Attachment #8659995 - Flags: review?(vporof)
Comment on attachment 8659995 [details] [diff] [review]
Patch v1

Review of attachment 8659995 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/webconsole.js
@@ +1976,1 @@
>      let toolbox = gDevTools.getToolbox(this.owner.target);

Drive-by: could you instead check if toolbox is null and return in that case?
Posted patch Patch v2Splinter Review
Sure.
Attachment #8659995 - Attachment is obsolete: true
Attachment #8659995 - Flags: review?(vporof)
Attachment #8660006 - Flags: review?(bgrinstead)
Comment on attachment 8660006 [details] [diff] [review]
Patch v2

Review of attachment 8660006 [details] [diff] [review]:
-----------------------------------------------------------------

seems fine, the browser toolbox will still work for jumping to the netmonitor if needed
Attachment #8660006 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/9ad4faa76255
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.