Status

Release Engineering
General Automation
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8660082 [details] [diff] [review]
enable pgo strategy on oak

I need to run tests on nightly builds on oak to see how xpcshell and mochitest-other do with the new sha-2 cert from DigiCert. I _think_ I just need to set pgo_strategy to do this, but I don't know how to verify that other than throwing this at the wall....
Attachment #8660082 - Flags: review?(catlee)
(Assignee)

Comment 1

2 years ago
So, I tried to do some verification of this. As expected, it adds both the PGO builders + test builders to oak. I only need the test builders, but I don't know of a way to not have the builders added as well. Because the sendchange is done by Mozharness now, dump_master.py isn't helpful in figuring out what that will look like. It currently does sendchanges such as:
10:38:30     INFO - Running command: ['c:\\mozilla-build\\python27\\python.exe', 'c:\\mozilla-build\\buildbotve\\scripts\\buildbot', 'sendchange', '--master', 'buildbot-master81.build.mozilla.org:9301', '--username', 'sendchange-unittest', '--branch', 'oak-win32-pgo-unittest', '-r', u'a7e06f6ac5ba9c141dae884c12c39eef7301c190', '--property', 'buildid:20150911040219', '--property', 'pgo_build:True', '--property', 'builduid:27aebd4a61764064adf423c14bac0760', '--property', 'nightly_build:True', u'https://queue.taskcluster.net/v1/task/xE2Zz8XvTrmseY7659ClJA/artifacts/public/build/firefox-43.0a1.en-US.win32.zip', u'https://queue.taskcluster.net/v1/task/xE2Zz8XvTrmseY7659ClJA/artifacts/public/build/test_packages.json']

So I assume that's not going to change with my patch. I did some hacking up of my local configs to try to match up the scheduler names with the builders, to confirm that they would actually be triggered, and it looks like they will:
oak-win32-opt-unittest
['Windows 7 32-bit oak opt test cppunit', 'Windows 7 32-bit oak opt test mochitest-1', 'Windows 7 32-bit oak opt test mochitest-2', 'Windows 7 32-bit oak opt test mochitest-3', 'Windows 7 32-bit oak opt test mochitest-4', 'Windows 7 32-bit oak opt test mochitest-5', 'Windows 7 32-bit oak opt test mochitest-other', 'Windows 7 32-bit oak opt test mochitest-devtools-chrome-1', 'Windows 7 32-bit oak opt test mochitest-devtools-chrome-2', 'Windows 7 32-bit oak opt test jsreftest', 'Windows 7 32-bit oak opt test crashtest', 'Windows 7 32-bit oak opt test mochitest-gl', 'Windows 7 32-bit oak opt test xpcshell', 'Windows 7 32-bit oak opt test jittest', 'Windows 7 32-bit oak opt test marionette', 'Windows 7 32-bit oak opt test reftest-no-accel', 'Windows 7 32-bit oak opt test reftest', 'Windows 7 32-bit oak opt test web-platform-tests-reftests', 'Windows 7 32-bit oak opt test web-platform-tests-1', 'Windows 7 32-bit oak opt test web-platform-tests-2', 'Windows 7 32-bit oak opt test web-platform-tests-3', 'Windows 7 32-bit oak opt test web-platform-tests-4', 'Windows 7 32-bit oak opt test mochitest-jetpack', 'Windows 7 32-bit oak opt test mochitest-push', 'Windows 7 32-bit oak opt test gtest', 'Windows 7 32-bit oak opt test mochitest-e10s-browser-chrome-1', 'Windows 7 32-bit oak opt test mochitest-e10s-browser-chrome-2', 'Windows 7 32-bit oak opt test mochitest-e10s-browser-chrome-3', 'Windows 7 32-bit oak opt test mochitest-browser-chrome-1', 'Windows 7 32-bit oak opt test mochitest-browser-chrome-2', 'Windows 7 32-bit oak opt test mochitest-browser-chrome-3']

Updated

2 years ago
Attachment #8660082 - Flags: review?(catlee) → review+
(Assignee)

Updated

2 years ago
Attachment #8660082 - Flags: checked-in+
(Assignee)

Comment 2

2 years ago
This worked, yay.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.