120409 - Content-Disposition header parsing needs to strip out "filename="

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 115176, comment #121

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Reviews?  It'd be nice not to ship 0.9.8 with that bug... :)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 65327 [details] [diff] [review]
Fix

sr=[e-mail]

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Use a variable for that string, per review comments

Comment 5

[Stuart Ballard]

Comment on attachment 65344 [details] [diff] [review]
Use a variable for that string, per review comments

r=[e-mail] (bz said it would be okay for me to give r= without
actually testing for such a trivial patch; if that's not okay it's his fault ;)
)

Setting has-super-review flag based on sr for previous patch

Comment 6

[Brendan Eich [:brendan]]

a=[e-mail] for checkin to the frozen 0.9.8 trunk.

/be

Comment 7

[Boris Zbarsky [:bzbarsky]]

checked into trunk.  Thanks for the quick responses, all.

Comment 8

[sairuh (rarely reading bugmail)]

tested by using Save Link As from the context menu for the "120409" link at the
top of this page. the resulting suggested filename is now "show_bug.cgi.html".
used 2002.01.29.xx comm verif bits on linux rh7.2, win2k and mac 10.1.2.

marking verified --but if this is still not the expected results, pls do reopen!