1204356 - [dev theme] Back button in the toolbar has additional border when tab history is expanded

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[arni2033]

Attachment: screenshot - [dev theme] Back button in the toolbar has additional border when tab history is expanded.png

STR:   (Win7_64, Nightly 43, 32bit, ID 20150910030225, new profile, safe mode)
1. Open Devtools (F12)
2. Open devtools preferences (Ctrl+Shift+O), set Light devtools theme
3. Open "https://ya.ru/" in a new tab
4. Type "ok.ru" in locaion bar in that tab and press Enter [now you have 2 entries in tab history]
5. Hover mouse over the "Back" button in the toolbar, press left mouse button and hold it for ~3 seconds to expand tab's history menu
6. Release left mouse button and move mouse away from "Back" button and menu (you can move mouse to the tabs toolbar)

Result:       "Back" button has additional border which looks just like 
              "back" button's border in default fx theme.
Expectations: "Back" button should look the same after Steps 5 and 6.

Comment 1

[:Gijs (back August 25; he/him)]

Attachment: MozReview Request: Bug 1204356 - fix back button state on devedition when mouse is not over open back button, r?bgrins

Bug 1204356 - fix back button state on devedition when mouse is not over open back button, r?bgrins

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8662417 [details]
MozReview Request: Bug 1204356 - fix back button state on devedition when mouse is not over open back button, r?bgrins

https://reviewboard.mozilla.org/r/19607/#review17587

::: browser/themes/windows/devedition.css:51
(Diff revision 1)
> +#back-button[open="true"] > .toolbarbutton-icon {

Looks like the box-shadow also is applied for this selector this: 

#back-button:not([disabled="true"]):hover:active > .toolbarbutton-icon

And also the rule applied on linux: https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.css#742

Are these important cases to handle?

https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1082

Comment 3

[:Gijs (back August 25; he/him)]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8662417 [details]
> MozReview Request: Bug 1204356 - fix back button state on devedition when
> mouse is not over open back button, r?bgrins
> 
> https://reviewboard.mozilla.org/r/19607/#review17587
> 
> ::: browser/themes/windows/devedition.css:51
> (Diff revision 1)
> > +#back-button[open="true"] > .toolbarbutton-icon {
> 
> Looks like the box-shadow also is applied for this selector this: 
> 
> #back-button:not([disabled="true"]):hover:active > .toolbarbutton-icon

it looks like this isn't specific enough to override

https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/devedition.css#38

When you try this with current nightly, the double border only shows up when the mouse stops hovering the button or its descendants (the menu).

So I think this selector as-is is good enough.
  
> And also the rule applied on linux:
> https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.
> css#742

Right, seems like we might need to do the same on Linux.

Comment 4

[:Gijs (back August 25; he/him)]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Brian Grinstead [:bgrins] from comment #2)
> > Comment on attachment 8662417 [details]
> > MozReview Request: Bug 1204356 - fix back button state on devedition when
> > mouse is not over open back button, r?bgrins
> > 
> > https://reviewboard.mozilla.org/r/19607/#review17587
> > 
> > ::: browser/themes/windows/devedition.css:51
> > (Diff revision 1)
> > > +#back-button[open="true"] > .toolbarbutton-icon {
> > 
> > Looks like the box-shadow also is applied for this selector this: 
> > 
> > #back-button:not([disabled="true"]):hover:active > .toolbarbutton-icon
> 
> it looks like this isn't specific enough to override
> 
> https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/
> devedition.css#38
> 
> When you try this with current nightly, the double border only shows up when
> the mouse stops hovering the button or its descendants (the menu).
> 
> So I think this selector as-is is good enough.
>   
> > And also the rule applied on linux:
> > https://dxr.mozilla.org/mozilla-central/source/browser/themes/linux/browser.
> > css#742
> 
> Right, seems like we might need to do the same on Linux.

Actually, I can't reproduce this issue on current Linux nightly.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8662417 [details]
MozReview Request: Bug 1204356 - fix back button state on devedition when mouse is not over open back button, r?bgrins

https://reviewboard.mozilla.org/r/19607/#review17593

Thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b2896463ae0a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b2896463ae0a

Comment 8

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced the bug with Firefox Nightly 43.0a1 (2015-09-13) on Linux, 64 Bit

This Bug is now verified as fixed on Latest Firefox Developer Edition 44.0a2 (2015-12-12) 

Build ID: 20151212004007
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0