Remove MediaSourceReader and old mediasource related code

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Unassigned)

Tracking

(Blocks 1 bug)

43 Branch
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(5 attachments)

It is now unused and won't be maintained any further.
Attachment #8660596 - Flags: review?(kinetik)
Blocks: 1193670
Attachment #8660609 - Flags: review?(cpearce)
Blocks: 1194088
Attachment #8660596 - Flags: review?(kinetik) → review+
Comment on attachment 8660597 [details] [diff] [review]
P2. Remove old MediaSource implementation.

Review of attachment 8660597 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/SourceBuffer.cpp
@@ +465,5 @@
>    if (aHasActiveTracks) {
>      if (!mActive) {
>        mActive = true;
>        mMediaSource->SourceBufferIsActive(this);
> +      mMediaSource->GetDecoder()->NotifyWaitingForResourcesStatusChanged();

Did you mean to remove the "mMediaSource->QueueInitializationEvent();" line here?
Attachment #8660597 - Flags: review?(cpearce) → review+
Attachment #8660598 - Flags: review?(cpearce) → review+
Attachment #8660599 - Flags: review?(cpearce) → review+
Attachment #8660609 - Flags: review?(cpearce) → review+
(In reply to Chris Pearce (:cpearce) from comment #6)
> Comment on attachment 8660597 [details] [diff] [review]
> P2. Remove old MediaSource implementation.
> 
> Review of attachment 8660597 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/media/mediasource/SourceBuffer.cpp
> @@ +465,5 @@
> >    if (aHasActiveTracks) {
> >      if (!mActive) {
> >        mActive = true;
> >        mMediaSource->SourceBufferIsActive(this);
> > +      mMediaSource->GetDecoder()->NotifyWaitingForResourcesStatusChanged();
> 
> Did you mean to remove the "mMediaSource->QueueInitializationEvent();" line
> here?

yes. it's only used by the old TrackBuffer ; on the new MSE, removed there or in one of the later patch is the same.

likely missed it when I went to split the patches
You need to log in before you can comment on or make changes to this bug.