1204419 - Remove MediaSourceReader and old mediasource related code

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

It is now unused and won't be maintained any further.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P1. Fix webm headers.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P2. Remove old MediaSource implementation.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P3. Remove now unused MediaDecoderReader functions.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: P4. Remove MediaDataDemuxer API no longer used.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: P5. Remove no longer used prefs.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8660597 [details] [diff] [review]
P2. Remove old MediaSource implementation.

Review of attachment 8660597 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/SourceBuffer.cpp
@@ +465,5 @@
>    if (aHasActiveTracks) {
>      if (!mActive) {
>        mActive = true;
>        mMediaSource->SourceBufferIsActive(this);
> +      mMediaSource->GetDecoder()->NotifyWaitingForResourcesStatusChanged();

Did you mean to remove the "mMediaSource->QueueInitializationEvent();" line here?

Comment 7

[Jean-Yves Avenard [:jya]]

(In reply to Chris Pearce (:cpearce) from comment #6)
> Comment on attachment 8660597 [details] [diff] [review]
> P2. Remove old MediaSource implementation.
> 
> Review of attachment 8660597 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/media/mediasource/SourceBuffer.cpp
> @@ +465,5 @@
> >    if (aHasActiveTracks) {
> >      if (!mActive) {
> >        mActive = true;
> >        mMediaSource->SourceBufferIsActive(this);
> > +      mMediaSource->GetDecoder()->NotifyWaitingForResourcesStatusChanged();
> 
> Did you mean to remove the "mMediaSource->QueueInitializationEvent();" line
> here?

yes. it's only used by the old TrackBuffer ; on the new MSE, removed there or in one of the later patch is the same.

likely missed it when I went to split the patches

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7335e2816efe
https://hg.mozilla.org/integration/mozilla-inbound/rev/1776e9b8e885
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6291c14c06d
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4e39e6d93eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc94443249c0

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7335e2816efe
https://hg.mozilla.org/mozilla-central/rev/1776e9b8e885
https://hg.mozilla.org/mozilla-central/rev/a6291c14c06d
https://hg.mozilla.org/mozilla-central/rev/d4e39e6d93eb
https://hg.mozilla.org/mozilla-central/rev/fc94443249c0