1204434 - Remove check of MediaDecoder::IsMediaSeekable from OggReader::ReadMetadata

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/68718290640b/dom/media/ogg/OggReader.cpp#l476

It looks like it is not necessary to check MediaDecoder::IsMediaSeekable because RangeEndTime() below only cares about if MediaResource is seekable.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffc8f98204a3

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1204434 - Remove check of MediaDecoder::IsMediaSeekable from OggReader::ReadMetadata.

Bug 1204434 - Remove check of MediaDecoder::IsMediaSeekable from OggReader::ReadMetadata.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Try looks green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffc8f98204a3

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8661642 [details]
MozReview Request: Bug 1204434 - Remove check of MediaDecoder::IsMediaSeekable from OggReader::ReadMetadata.

https://reviewboard.mozilla.org/r/19419/#review17483

Looks like a reasonable assumption...

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9efbf9792f34

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9efbf9792f34