1204442 - nsIDragService shouldn't expose the internal event message as integer with fireDragEventAtSource()

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://mxr.mozilla.org/mozilla-central/source/widget/nsIDragService.idl?rev=1eec2c8789c1&mark=114-117#114

nsIDragService.fireDragEventAtSource() takes an integer value whose value is one of mozilla::EventMessage. This is too bad. The value shouldn't be able to be specified without EventMessage enum. We should make it noscript. Fortunately, nobody uses the method in AMO.
https://mxr.mozilla.org/addons/search?string=fireDragEventAtSource

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7ca9029fdbc

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: nsIDragService::FireDragEventAtSource() shouldn't be available from script because it takes a value of mozilla::EventMessage

Let's make it [noscript].

# Or roc is better reviewer due to XP widget code?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/13dc20d39faec37148234c5e2eb493be3a407ba5
changeset:  13dc20d39faec37148234c5e2eb493be3a407ba5
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:18:29 2015 +0900
description:
Bug 1204442 nsIDragService::FireDragEventAtSource() shouldn't be available from script because it takes a value of mozilla::EventMessage r=smaug, sr=smaug

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13dc20d39fae