1204564 - [markup-view] Inline text with "\n"s isn't being scrolled into view when I DoubleClick it for editing

Status: VERIFIED DUPLICATE of bug 1143742

(DevTools :: Inspector, defect)

Description

[arni2033]

Attachment: screenshot - [markup-view] Inline text isn't being scrolled into view when I DoubleClick it for editing.png

STR:
1. Open this "data:" url or click URL in the form above
>   data:text/html,<div>Sample text%0A</div>
2. Open devtools->Inspector
3. Doubleclick the inline text in markup-view

Result:       Only a small blue line is visible at the top of textarea in markup-view
Expectations: Text should be visible when I start editing it

Comment 1

[arni2033]

Yeah, this too.

Comment 2

[Patrick Brosset <:pbro>]

The inplace-editor used here is set to be in multiline mode (see the TextEditor class in devtools/client/markupview/markup-view.js).
And in multiline mode, the textarea used to edit the text gets its dimension dynamically determined by somehow measuring the text (see _autosize in devtools/client/shared/inplace-editor.js).

On this page: data:text/html,<div>Sample text%0Amore text</div>
The textarea is correctly sized to accommodate both lines of text.

Comment 3

[Julian Descottes [:jdescottes]]

Fixed on Firefox 48, most likely by Bug 1143742.

Comment 4

[Martin Thomson [:mt:]]

Attachment: Bug 1204564 - Update NSS to 7289ef6a8b84,

Review commit: https://reviewboard.mozilla.org/r/80298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80298/

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 8793580 [details]
Bug 1204564 - Update NSS to 7289ef6a8b84,

https://reviewboard.mozilla.org/r/80298/#review78938

::: security/nss/coreconf/coreconf.dep:13
(Diff revision 1)
>   * Used to force a full recompilation of NSS in Mozilla's Tinderbox
>   * depend builds.  See comments in rules.mk.
>   */
>  
>  #error "Do not include this header file."
> +

What happened here?

Comment 6

[Eric Rescorla (:ekr)]

Comment on attachment 8793580 [details]
Bug 1204564 - Update NSS to 7289ef6a8b84,

https://reviewboard.mozilla.org/r/80296/#review78940

LGTM. I can't figure out how to mark it ship it

Comment 7

[Martin Thomson [:mt:]]

Comment on attachment 8793580 [details]
Bug 1204564 - Update NSS to 7289ef6a8b84,

https://reviewboard.mozilla.org/r/80298/#review78938

> What happened here?

The script that lands NSS adds (or removes) this blank line so that the rest of the firefox build can see that NSS has changed.  It's crazy.  Take a look at client.py.

Comment 8

[Julian Descottes [:jdescottes]]

I think you are discussing about Bug 1304564 here. Could you amend your commit message before landing?

Comment 9

[Martin Thomson [:mt:]]

Yeah, pilot error on my part.  Already corrected.