1204585 - [css-grid] wrong abs pos CB position with some writing-mode combinations

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mats Palmgren (inactive)]

Attachment: testcase

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

Comment 2

[Mats Palmgren (inactive)]

Attachment: reftests

Comment 3

[Mats Palmgren (inactive)]

This is for an earlier version of the patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d218f409200
before I realized I could move the expression outside of the loop.
It doesn't seem necessary to run another job for that minor change
(I checked they still pass locally though).

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8661225 [details] [diff] [review]
fix

Review of attachment 8661225 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGridContainerFrame.cpp
@@ +2425,5 @@
>        const LogicalPoint gridOrigin(wm, pad.IStart(wm), pad.BStart(wm));
>        const LogicalRect gridCB(wm, 0, 0,
>                                 aContentArea.ISize(wm) + pad.IStartEnd(wm),
>                                 aContentArea.BSize(wm) + pad.BStartEnd(wm));
> +      const nsSize gridCBPysicalSize = gridCB.Size(wm).GetPhysicalSize(wm);

Nit: s/gridPysical/gridPhysical/  (missing an "h")

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a31775ecf4e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/c87dd24d1143

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a31775ecf4e2
https://hg.mozilla.org/mozilla-central/rev/c87dd24d1143