Closed Bug 1204585 Opened 6 years ago Closed 6 years ago

[css-grid] wrong abs pos CB position with some writing-mode combinations

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: testcase)

Attachments

(3 files)

Attached file testcase
No description provided.
Attached patch fixSplinter Review
Attachment #8661225 - Flags: review?(dholbert)
Attached patch reftestsSplinter Review
This is for an earlier version of the patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d218f409200
before I realized I could move the expression outside of the loop.
It doesn't seem necessary to run another job for that minor change
(I checked they still pass locally though).
Comment on attachment 8661225 [details] [diff] [review]
fix

Review of attachment 8661225 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGridContainerFrame.cpp
@@ +2425,5 @@
>        const LogicalPoint gridOrigin(wm, pad.IStart(wm), pad.BStart(wm));
>        const LogicalRect gridCB(wm, 0, 0,
>                                 aContentArea.ISize(wm) + pad.IStartEnd(wm),
>                                 aContentArea.BSize(wm) + pad.BStartEnd(wm));
> +      const nsSize gridCBPysicalSize = gridCB.Size(wm).GetPhysicalSize(wm);

Nit: s/gridPysical/gridPhysical/  (missing an "h")
Attachment #8661225 - Flags: review?(dholbert) → review+
Blocks: 1208584
You need to log in before you can comment on or make changes to this bug.