Closed
Bug 1204635
Opened 9 years ago
Closed 9 years ago
Bring back old Clear Private Data strings
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.1+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
Attachments
(1 file)
A bunch of Clear Private Data strings have disappeared on master because they have been replaced with newer strings to follow changes the feature.
However, we still need to build 1.0.x releases with strings from master, so this bug is about bringing back those strings temporarily.
This is about the following:
<file original="Client/ClearPrivateData.strings" source-language="en" datatype="plaintext" target-language="bg">
<header>
<tool tool-id="com.apple.dt.xcode" tool-name="Xcode" tool-version="6.4" build-num="6E35b"/>
</header>
<body>
<trans-unit id="Are you sure you want to clear all of your data? This will also close all open tabs.">
<source>Are you sure you want to clear all of your data? This will also close all open tabs.</source>
<target>Сигурни ли сте, че искате да заличите всичките данни? Отворените подпрозорци ще бъдат затворени.</target>
<note>Message shown in the dialog prompting users if they want to clear everything</note>
</trans-unit>
<trans-unit id="Cancel">
<source>Cancel</source>
<target>Отказ</target>
<note>Used as a button label in the dialog to cancel clear private data dialog</note>
</trans-unit>
<trans-unit id="Clear">
<source>Clear</source>
<target>Изчистване</target>
<note>Used as a button label in the dialog to Clear private data dialog</note>
</trans-unit>
<trans-unit id="Clear Everything">
<source>Clear Everything</source>
<target>Изчистване всичко</target>
<note>Title of the Clear private data dialog.</note>
</trans-unit>
</body>
</file>
These strings can simply come back as some global variables for example.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8660908 -
Flags: review?(sleroux)
Attachment #8660908 -
Flags: feedback?(francesco.lodolo)
|
||
Updated•9 years ago
|
Attachment #8660908 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8660908 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1066
Post f+. Also verified that the diff looks good after this merged.
Attachment #8660908 -
Flags: feedback?(francesco.lodolo) → feedback+
|
|
||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•