Closed
Bug 1204655
Opened 9 years ago
Closed 9 years ago
Respond to a main launcher intent with category APP_BROWSER selector
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: tynn, Assigned: tynn)
References
Details
Attachments
(1 file)
1.55 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Launching an intent created with Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER) starts any other browser but Firefox or none if Firefox is the only Browser installed.
Assignee | ||
Comment 1•9 years ago
|
||
Hallo Michael, I've just added the APP_BROWSER category to the only launcher intent available, which resolves the issue and shouldn't have any side effects.
Attachment #8660936 -
Flags: review?(michael.l.comella)
Hey Christian, I'll get to this tomorrow.
Assignee: nobody → tynn.dev
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8660936 [details] [diff] [review] bug1204655.patch Review of attachment 8660936 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, Christian! Thanks! try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4df58168e7a Out of curiosity, how did you find out about this bug? Are there many applications that create intents this way?
Attachment #8660936 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
I've used this intent once and my tests failed on one device running Firefox and no other browser. But I don't know of any other application using it.
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/90ad1f7de0b0
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•