1204655 - Respond to a main launcher intent with category APP_BROWSER selector

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Schmitz (:tynn)]

Launching an intent created with Intent.makeMainSelectorActivity(Intent.ACTION_MAIN, Intent.CATEGORY_APP_BROWSER) starts any other browser but Firefox or none if Firefox is the only Browser installed.

Comment 1

[Christian Schmitz (:tynn)]

Attachment: bug1204655.patch

Hallo Michael, I've just added the APP_BROWSER category to the only launcher intent available, which resolves the issue and shouldn't have any side effects.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey Christian, I'll get to this tomorrow.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8660936 [details] [diff] [review]
bug1204655.patch

Review of attachment 8660936 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Christian! Thanks!

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4df58168e7a

Out of curiosity, how did you find out about this bug? Are there many applications that create intents this way?

Comment 4

[Christian Schmitz (:tynn)]

I've used this intent once and my tests failed on one device running Firefox and no other browser. But I don't know of any other application using it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/90ad1f7de0b0

Comment 6

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/90ad1f7de0b0