Closed Bug 1204793 Opened 7 years ago Closed 7 years ago

[Testcase] Unregister AudioChannelAgent when its volume changes to ZERO or be muted

Categories

(Firefox OS Graveyard :: AudioChannel, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox46 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

Details

Attachments

(1 file)

User scenario.
1. Play music in background
2. Watch silent video in other app (ex. FB would autoplay the silent video)

Expected.
3. Music should not be interrupted.

We need the patch and test for this scenario.

---

[Conclusion]
If the audio/video is playing, unregister agent when,
(1) It is muted.
(2) Its volume becomes ZERO.

If the audio/video is playing, register agent when,
(1) It is unmuted.
(2) Its volume becomes NON-ZERO.
Already be done in the current master.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
But we have no the test for this case yet, reopen it and change the tittle.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Unregister audio agent when the audio/video is muted or zero volume → [Testcase] Unregister AudioChannelAgent when its volume changes to ZERO or be muted
Status: REOPENED → NEW
Blocks: 1223298
Bug 1204793 - testcase for checking the agent active state when changing the volume.
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/
Attachment #8688914 - Flags: review?(amarchesini)
Attachment #8688914 - Flags: review?(amarchesini) → review+
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

https://reviewboard.mozilla.org/r/25447/#review23047

We do have a similar test: test_noAudioNotificationOnMutedOrVolume0Element.html
Ah, sorry I didn't notice that!r
If I change this test to check whether the "activitychange" can be sent correctly, do you think is that ok?
Flags: needinfo?(amarchesini)
Sure.
Flags: needinfo?(amarchesini)
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/
Depends on: 1228564
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/2-3/
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Hi, Baku,
I modified this patch to check "activitychange" event when the muted or volume changing.
Could you help me review it again?
Very appreciate!
Attachment #8688914 - Flags: review+ → review?(amarchesini)
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.

https://reviewboard.mozilla.org/r/25447/#review26343
Attachment #8688914 - Flags: review?(amarchesini) → review+
Thanks :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7b7b730f7f8e
Status: NEW → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.