Closed
Bug 1204793
Opened 9 years ago
Closed 9 years ago
[Testcase] Unregister AudioChannelAgent when its volume changes to ZERO or be muted
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file)
User scenario.
1. Play music in background
2. Watch silent video in other app (ex. FB would autoplay the silent video)
Expected.
3. Music should not be interrupted.
We need the patch and test for this scenario.
---
[Conclusion]
If the audio/video is playing, unregister agent when,
(1) It is muted.
(2) Its volume becomes ZERO.
If the audio/video is playing, register agent when,
(1) It is unmuted.
(2) Its volume becomes NON-ZERO.
Assignee | ||
Comment 1•9 years ago
|
||
Already be done in the current master.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 2•9 years ago
|
||
But we have no the test for this case yet, reopen it and change the tittle.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Updated•9 years ago
|
Summary: Unregister audio agent when the audio/video is muted or zero volume → [Testcase] Unregister AudioChannelAgent when its volume changes to ZERO or be muted
Assignee | ||
Updated•9 years ago
|
Status: REOPENED → NEW
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1204793 - testcase for checking the agent active state when changing the volume.
Assignee | ||
Comment 4•9 years ago
|
||
Try-server result.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e61bada6969
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/
Attachment #8688914 -
Flags: review?(amarchesini)
Updated•9 years ago
|
Attachment #8688914 -
Flags: review?(amarchesini) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
https://reviewboard.mozilla.org/r/25447/#review23047
We do have a similar test: test_noAudioNotificationOnMutedOrVolume0Element.html
Assignee | ||
Comment 7•9 years ago
|
||
Ah, sorry I didn't notice that!r
If I change this test to check whether the "activitychange" can be sent correctly, do you think is that ok?
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/1-2/
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/2-3/
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Hi, Baku,
I modified this patch to check "activitychange" event when the muted or volume changing.
Could you help me review it again?
Very appreciate!
Attachment #8688914 -
Flags: review+ → review?(amarchesini)
Assignee | ||
Comment 13•9 years ago
|
||
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25447/diff/3-4/
Comment 15•9 years ago
|
||
Comment on attachment 8688914 [details]
MozReview Request: Bug 1204793 - testcase for checking the agent active state when changing the volume.
https://reviewboard.mozilla.org/r/25447/#review26343
Attachment #8688914 -
Flags: review?(amarchesini) → review+
Comment 17•9 years ago
|
||
Keywords: checkin-needed
Comment 18•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago → 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•