All users were logged out of Bugzilla on October 13th, 2018

Check meta/global engines in Sync app

RESOLVED FIXED in FxOS-S11 (13Nov)

Status

P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mbdejong, Assigned: mbdejong)

Tracking

unspecified
FxOS-S11 (13Nov)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
"The client needs to validate the meta/global record on every request." https://docs.services.mozilla.com/sync/lifeofasync.html

But:
[info/collections] is a utility API provided by the storage service that reveals which collections exist on the server and when they were last modified.

That means we can save work, as follows:
* Retrieve info/collections.
* If none of the data collections we need have have changed according to info/collections, stop here.
* Retrieve meta/global and check storage format.
* Only retrieve crypto/keys if it has changed according to info/collections.
* Only retrieve data collections that have changed according to info/collections.
(Assignee)

Updated

3 years ago
Assignee: nobody → mbdejong
Blocks: 1195647
Target Milestone: --- → FxOS-S11 (13Nov)
Priority: -- → P3
(Assignee)

Comment 1

3 years ago
Looks like info/collections was moved to meta/global.engines
Created attachment 8686123 [details] [review]
[gaia] michielbdejong:1204830-check-metaglobal-engines > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Summary: Fetch info/collections in Sync app → Check meta/global engines in Sync app
(Assignee)

Comment 3

3 years ago
Comment on attachment 8686123 [details] [review]
[gaia] michielbdejong:1204830-check-metaglobal-engines > mozilla-b2g:master

See http://docs.services.mozilla.com/sync/storageformat5.html#metaglobal-record
Attachment #8686123 - Flags: review?(ferjmoreno)
(Assignee)

Comment 4

3 years ago
(In reply to Michiel de Jong [:michielbdejong] from comment #1)
> Looks like info/collections was moved to meta/global.engines

Created https://github.com/mozilla-services/docs/issues/55 about the docs issue.
Attachment #8686123 - Flags: review?(ferjmoreno) → review+
(Assignee)

Comment 5

3 years ago
Turns out Syncto doesn't support retrieving info/collections. I'm not so sure anymore now whether we really need this.
(Assignee)

Comment 6

3 years ago
If we check meta/globals for the engines like in this patch, then I think it's not so important to also check info/collections (would only be a performance optimization when syncing many collections, and for now we're only syncing one or two).
(Assignee)

Comment 7

3 years ago
What do you think, shall we just merge this to check the engines from m/g, and then leave it at that?
Flags: needinfo?(ferjmoreno)
Sounds good to me.
Flags: needinfo?(ferjmoreno)
https://github.com/mozilla-b2g/gaia/commit/1e9a2a701dec486dd94bdb925019bb6ead8291ca
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.