1204968 - "just now" and "x minutes ago" text is still in English when phone is in various languages

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of Flame in French

Seen while running on Flame using https://github.com/mozilla/buddyup/commit/33717e78aba29942cc27d496bdb2d437f5e3705f.

STR:
1. Install the latest BuddyUp with a device which is either in French or Italian
2. See attached screenshot in French

spoke with Theo on irc, he said "we should check with devs what are their plans. I'd guess they want to use Firefox OS's date.properties"

Comment 1

[Michael Cooper [:mythmon]]

It seems this is a known problem in the code: https://github.com/mozilla/buddyup/blob/33717e78aba29942cc27d496bdb2d437f5e3705f/app/js/utils.js#L116-L117

I'm not familiar with mozl10n to know where to go from here, but we can look into it.

Comment 2

[Théo Chevalier]

Gandalf, from comment#1, do you have any recommendation about what external Apps like BuddyUp should be using for time formatting? Should they try using the new MozIntl lib through Gaia or mozL10n, or something else?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

mozIntl requires mozL10n, so if BuddyUp is interested in both then yeah, we have a solution. But last time I checked BuddyUp was moving away from mozL10n, which makes mozIntl not an appropriate solution.

Comment 4

[Michael Cooper [:mythmon]]

I'm not interested in moving BuddyUp to mozL10n (not because I don't like mozL10n, simply because I don't want to move BuddyUp to anything). We can do this naively with things like _('just now') or _('{minutes} ago').

Comment 5

[Michael Cooper [:mythmon]]

This isn't 0 points (even though it is under the meta bug)

Comment 6

[Michael Cooper [:mythmon]]

This is merged to master: like other l10n bugs, it will take some time for strings to actually become localized, but now they are localizable.